From: David Brownell <david-b@pacbell.net>
To: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
Cc: linux-kernel@vger.kernel.org, mikael.starvik@axis.com,
spi-devel-general@lists.sourceforge.net
Subject: Re: [PATCH 1/2] take 2: (was-kind-of: 3/5 SPI tx_default) 2.6.20-rc6
Date: Sat, 27 Jan 2007 11:25:32 -0800 [thread overview]
Message-ID: <200701271125.33121.david-b@pacbell.net> (raw)
In-Reply-To: <200701271011.l0RAB3MD018814@ignucius.se.axis.com>
On Saturday 27 January 2007 2:11 am, Hans-Peter Nilsson wrote:
> > From: David Brownell <david-b@pacbell.net>
> > Date: Fri, 26 Jan 2007 15:21:15 -0800
>
> > > > That flag could work in conjunction with a byte
> > >
> > > Or why not a 32-bit word!
> >
> > If a driver wants a repeating 32-bit pattern, they should just
> > provide a properly initialized tx buffer.
>
> I'm suggesting the default_tx_word be able to fill out "common"
> values of bits_per_word when > 8, else it'd be useless as a
> 1-filler for larger sizes than byte. Making it a single bit
> then wouldn't cater to your debug-with-scope use-case.
That wasn't my idea, it was borrowed from someone else's debug
arsenal. ;)
In any case, I think that sort of debug assist doesn't need to
stay in production system. See the patch I posted previously...
- Dave
next prev parent reply other threads:[~2007-01-27 19:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 4:52 [PATCH] 3/5: Updates to SPI and mmc_spi: tx_default, kernel 2.6.19 Hans-Peter Nilsson
2007-01-25 13:02 ` David Brownell
2007-01-26 10:46 ` [PATCH 1/2] take 2: (was-kind-of: 3/5 SPI tx_default) 2.6.20-rc6 Hans-Peter Nilsson
2007-01-26 23:21 ` David Brownell
2007-01-27 4:21 ` David Brownell
2007-01-27 20:19 ` Hans-Peter Nilsson
2007-01-27 20:26 ` Hans-Peter Nilsson
2007-01-27 20:59 ` [PATCH] take 3: mmc_spi with SPI_TX_1 2.6.20-rc6 Hans-Peter Nilsson
2007-01-28 17:46 ` [PATCH] take 4: " Hans-Peter Nilsson
2007-01-27 10:11 ` [PATCH 1/2] take 2: (was-kind-of: 3/5 SPI tx_default) 2.6.20-rc6 Hans-Peter Nilsson
2007-01-27 19:25 ` David Brownell [this message]
2007-01-26 10:48 ` [PATCH 2/2] " Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701271125.33121.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=hans-peter.nilsson@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikael.starvik@axis.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox