* [patch] use __u32 rather than u32 in userspace ioctls in usbdevice_fs.h
@ 2007-01-28 12:23 Mike Frysinger
2007-01-28 17:42 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Mike Frysinger @ 2007-01-28 12:23 UTC (permalink / raw)
To: linux-usb-devel; +Cc: linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 135 bytes --]
the trivial attached patch fixes ioctl defines in usbdevice_fs.h that are
exported to userspace to use __u32 rather than u32
-mike
[-- Attachment #1.2: Type: application/pgp-signature, Size: 827 bytes --]
[-- Attachment #2: linux-use-__-types-in-usbdevice-fs-header.patch --]
[-- Type: text/x-diff, Size: 896 bytes --]
Use __u32 rather than u32 in userspace ioctl defines.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
--- a/include/linux/usbdevice_fs.h
+++ b/include/linux/usbdevice_fs.h
@@ -159,9 +159,9 @@ struct usbdevfs_ioctl32 {
#define USBDEVFS_SUBMITURB32 _IOR('U', 10, struct usbdevfs_urb32)
#define USBDEVFS_DISCARDURB _IO('U', 11)
#define USBDEVFS_REAPURB _IOW('U', 12, void *)
-#define USBDEVFS_REAPURB32 _IOW('U', 12, u32)
+#define USBDEVFS_REAPURB32 _IOW('U', 12, __u32)
#define USBDEVFS_REAPURBNDELAY _IOW('U', 13, void *)
-#define USBDEVFS_REAPURBNDELAY32 _IOW('U', 13, u32)
+#define USBDEVFS_REAPURBNDELAY32 _IOW('U', 13, __u32)
#define USBDEVFS_DISCSIGNAL _IOR('U', 14, struct usbdevfs_disconnectsignal)
#define USBDEVFS_CLAIMINTERFACE _IOR('U', 15, unsigned int)
#define USBDEVFS_RELEASEINTERFACE _IOR('U', 16, unsigned int)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] use __u32 rather than u32 in userspace ioctls in usbdevice_fs.h
2007-01-28 12:23 [patch] use __u32 rather than u32 in userspace ioctls in usbdevice_fs.h Mike Frysinger
@ 2007-01-28 17:42 ` Randy Dunlap
2007-01-28 22:24 ` Mike Frysinger
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2007-01-28 17:42 UTC (permalink / raw)
To: Mike Frysinger; +Cc: linux-usb-devel, linux-kernel
On Sun, 28 Jan 2007 07:23:57 -0500 Mike Frysinger wrote:
> the trivial attached patch fixes ioctl defines in usbdevice_fs.h that are
> exported to userspace to use __u32 rather than u32
Hi Mike,
Have you now audited all ioctls (and sent patches) for this misbehavior?
---
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] use __u32 rather than u32 in userspace ioctls in usbdevice_fs.h
2007-01-28 17:42 ` Randy Dunlap
@ 2007-01-28 22:24 ` Mike Frysinger
0 siblings, 0 replies; 3+ messages in thread
From: Mike Frysinger @ 2007-01-28 22:24 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-usb-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 389 bytes --]
On Sunday 28 January 2007 12:42, Randy Dunlap wrote:
> Have you now audited all ioctls (and sent patches) for this misbehavior?
my audit involved grepping the headers for '\<[us](8|16|32|64)\>' and sending
patches for the headers that came up
ive sent patches for all except for asm-parisc/statfs.h ... but i'll do that
shortly once i finish pulling the parisc git tree
-mike
[-- Attachment #2: Type: application/pgp-signature, Size: 827 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-01-28 22:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-01-28 12:23 [patch] use __u32 rather than u32 in userspace ioctls in usbdevice_fs.h Mike Frysinger
2007-01-28 17:42 ` Randy Dunlap
2007-01-28 22:24 ` Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox