Re: i965 testers wanted (Re: intel-agp PM experiences)

[Dave Jones <davej@redhat.com>]

On Mon, Jan 29, 2007 at 11:21:31PM +0100, Frédéric Riss wrote:
 > Le lundi 29 janvier 2007 à 23:10 +0100, Pavel Machek a écrit :
 > > > > Ok, I guess we'd like some testing here... so that in can be fixed in
 > > > > mainline...
 > > > 
 > > > I can confirm that this patch is needed for my Intel Mac Mini to resume
 > > > correctly when used without BIOS emulation (EFI mode). Here're the
 > > > relevant lspci lines:
 > > 
 > > Can you attach the patch you tested (there was link above, but it did
 > > not work for me), and try pushing it through maintainers?
 > 
 > I inlined the patch I used below. If I'm not mistaken, the maintainer is
 > Davej which is already in the Cc: list. I think it's exactly the same as
 > was submitted in http://lkml.org/lkml/2007/1/16/297 (I may have hand
 > copied it though, can't remember). The above link is more complete as it
 > contains the Signed-off-by and a description.
 > 
 > diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c
 > index ab0a9c0..f64a115 100644
 > --- a/drivers/char/agp/intel-agp.c
 > +++ b/drivers/char/agp/intel-agp.c
 > @@ -1955,6 +1955,15 @@ static int agp_intel_resume(struct pci_d
 >  
 >  	pci_restore_state(pdev);
 >  
 > +	/* We should restore our graphics device's config space,
 > +	 * as host bridge (00:00) resumes before graphics device (02:00),
 > +	 * then our access to its pci space can work right. 
 > +	 */
 > +	if (intel_i810_private.i810_dev)
 > +		pci_restore_state(intel_i810_private.i810_dev);
 > +	if (intel_i830_private.i830_dev)
 > +		pci_restore_state(intel_i830_private.i830_dev);

This has been in agpgart.git since the 17th.
I asked Linus to pull last night.

		Dave

-- 
http://www.codemonkey.org.uk