From: Len Brown <lenb@kernel.org>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] ACPI: Correct apparent typo "CONFIG_ACPI_DEBUG_OUTPUT".
Date: Tue, 30 Jan 2007 02:17:09 -0500 [thread overview]
Message-ID: <200701300217.09406.lenb@kernel.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0701270145540.32670@CPE00045a9c397f-CM001225dbafb6>
Heh, you're right Robert -- this was a typo.
So I applied your patch, looked at my dmesg and realized that
we don't need the output it enables, so I deleted the whole routine:-)
thanks,
-Len
On Saturday 27 January 2007 01:55, Robert P. J. Day wrote:
>
> Replace the apparent typo CONFIG_ACPI_DEBUG_OUTPUT with
> the non-Kconfig conditional ACPI_DEBUG_OUTPUT, which is what every
> other file uses.
>
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
>
> ---
>
> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> index 698a154..d65142a 100644
> --- a/drivers/acpi/scan.c
> +++ b/drivers/acpi/scan.c
> @@ -891,7 +891,7 @@ static int acpi_device_set_context(struct acpi_device *device, int type)
> static void acpi_device_get_debug_info(struct acpi_device *device,
> acpi_handle handle, int type)
> {
> -#ifdef CONFIG_ACPI_DEBUG_OUTPUT
> +#ifdef ACPI_DEBUG_OUTPUT
> char *type_string = NULL;
> char name[80] = { '?', '\0' };
> struct acpi_buffer buffer = { sizeof(name), name };
> @@ -928,7 +928,7 @@ static void acpi_device_get_debug_info(struct acpi_device *device,
> }
>
> printk(KERN_DEBUG "Found %s %s [%p]\n", type_string, name, handle);
> -#endif /*CONFIG_ACPI_DEBUG_OUTPUT */
> +#endif /* ACPI_DEBUG_OUTPUT */
> }
>
> static int acpi_bus_remove(struct acpi_device *dev, int rmdevice)
>
prev parent reply other threads:[~2007-01-30 7:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-27 6:55 [PATCH] ACPI: Correct apparent typo "CONFIG_ACPI_DEBUG_OUTPUT" Robert P. J. Day
2007-01-30 7:17 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701300217.09406.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox