* [PATCH] ACPI: Correct apparent typo "CONFIG_ACPI_DEBUG_OUTPUT".
@ 2007-01-27 6:55 Robert P. J. Day
2007-01-30 7:17 ` Len Brown
0 siblings, 1 reply; 2+ messages in thread
From: Robert P. J. Day @ 2007-01-27 6:55 UTC (permalink / raw)
To: Linux kernel mailing list; +Cc: Andrew Morton, len.brown
Replace the apparent typo CONFIG_ACPI_DEBUG_OUTPUT with
the non-Kconfig conditional ACPI_DEBUG_OUTPUT, which is what every
other file uses.
Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
---
diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
index 698a154..d65142a 100644
--- a/drivers/acpi/scan.c
+++ b/drivers/acpi/scan.c
@@ -891,7 +891,7 @@ static int acpi_device_set_context(struct acpi_device *device, int type)
static void acpi_device_get_debug_info(struct acpi_device *device,
acpi_handle handle, int type)
{
-#ifdef CONFIG_ACPI_DEBUG_OUTPUT
+#ifdef ACPI_DEBUG_OUTPUT
char *type_string = NULL;
char name[80] = { '?', '\0' };
struct acpi_buffer buffer = { sizeof(name), name };
@@ -928,7 +928,7 @@ static void acpi_device_get_debug_info(struct acpi_device *device,
}
printk(KERN_DEBUG "Found %s %s [%p]\n", type_string, name, handle);
-#endif /*CONFIG_ACPI_DEBUG_OUTPUT */
+#endif /* ACPI_DEBUG_OUTPUT */
}
static int acpi_bus_remove(struct acpi_device *dev, int rmdevice)
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://www.fsdev.dreamhosters.com/wiki/index.php?title=Main_Page
========================================================================
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ACPI: Correct apparent typo "CONFIG_ACPI_DEBUG_OUTPUT".
2007-01-27 6:55 [PATCH] ACPI: Correct apparent typo "CONFIG_ACPI_DEBUG_OUTPUT" Robert P. J. Day
@ 2007-01-30 7:17 ` Len Brown
0 siblings, 0 replies; 2+ messages in thread
From: Len Brown @ 2007-01-30 7:17 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: Linux kernel mailing list, Andrew Morton
Heh, you're right Robert -- this was a typo.
So I applied your patch, looked at my dmesg and realized that
we don't need the output it enables, so I deleted the whole routine:-)
thanks,
-Len
On Saturday 27 January 2007 01:55, Robert P. J. Day wrote:
>
> Replace the apparent typo CONFIG_ACPI_DEBUG_OUTPUT with
> the non-Kconfig conditional ACPI_DEBUG_OUTPUT, which is what every
> other file uses.
>
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
>
> ---
>
> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> index 698a154..d65142a 100644
> --- a/drivers/acpi/scan.c
> +++ b/drivers/acpi/scan.c
> @@ -891,7 +891,7 @@ static int acpi_device_set_context(struct acpi_device *device, int type)
> static void acpi_device_get_debug_info(struct acpi_device *device,
> acpi_handle handle, int type)
> {
> -#ifdef CONFIG_ACPI_DEBUG_OUTPUT
> +#ifdef ACPI_DEBUG_OUTPUT
> char *type_string = NULL;
> char name[80] = { '?', '\0' };
> struct acpi_buffer buffer = { sizeof(name), name };
> @@ -928,7 +928,7 @@ static void acpi_device_get_debug_info(struct acpi_device *device,
> }
>
> printk(KERN_DEBUG "Found %s %s [%p]\n", type_string, name, handle);
> -#endif /*CONFIG_ACPI_DEBUG_OUTPUT */
> +#endif /* ACPI_DEBUG_OUTPUT */
> }
>
> static int acpi_bus_remove(struct acpi_device *dev, int rmdevice)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-01-30 7:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-01-27 6:55 [PATCH] ACPI: Correct apparent typo "CONFIG_ACPI_DEBUG_OUTPUT" Robert P. J. Day
2007-01-30 7:17 ` Len Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox