From: Alan <alan@lxorguk.ukuu.org.uk>
To: ethanhsiao@jmicron.com
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, alan@redhat.com
Subject: Re: [PATCH -mm] jmicron: 40/80pin primary detection
Date: Tue, 30 Jan 2007 14:31:56 +0000 [thread overview]
Message-ID: <20070130143156.41480254@localhost.localdomain> (raw)
In-Reply-To: <OF59067410.11A20F48-ON48257273.00150F04@jmicron.com>
> case PORT_PATA0:
> if (control & (1 << 3)) /* 40/80 pin primary */
> - return 1;
> - return 0;
> + return 0;
> + return 1;
Ack
> @@ -205,11 +205,11 @@
> }
>
> static struct pci_device_id jmicron_pci_tbl[] = {
> - { PCI_DEVICE(PCI_VENDOR_ID_JMICRON, PCI_DEVICE_ID_JMICRON_JMB361), 0},
> - { PCI_DEVICE(PCI_VENDOR_ID_JMICRON, PCI_DEVICE_ID_JMICRON_JMB363), 1},
> - { PCI_DEVICE(PCI_VENDOR_ID_JMICRON, PCI_DEVICE_ID_JMICRON_JMB365), 2},
> - { PCI_DEVICE(PCI_VENDOR_ID_JMICRON, PCI_DEVICE_ID_JMICRON_JMB366), 3},
> - { PCI_DEVICE(PCI_VENDOR_ID_JMICRON, PCI_DEVICE_ID_JMICRON_JMB368), 4},
> + { PCI_VENDOR_ID_JMICRON, PCI_DEVICE_ID_JMICRON_JMB361, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
> + { PCI_VENDOR_ID_JMICRON, PCI_DEVICE_ID_JMICRON_JMB363, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1},
> + { PCI_VENDOR_ID_JMICRON, PCI_DEVICE_ID_JMICRON_JMB365, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 2},
> + { PCI_VENDOR_ID_JMICRON, PCI_DEVICE_ID_JMICRON_JMB366, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 3},
> + { PCI_VENDOR_ID_JMICRON, PCI_DEVICE_ID_JMICRON_JMB368, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 4},
> { 0, },
That should have been fixed a while ago with the others that had that
same bug. Must have escaped somewhere.
Acked-by: Alan Cox <alan@redhat.com>
prev parent reply other threads:[~2007-01-30 14:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-30 4:03 [PATCH -mm] jmicron: 40/80pin primary detection ethanhsiao
2007-01-30 14:31 ` Alan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070130143156.41480254@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@redhat.com \
--cc=ethanhsiao@jmicron.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox