public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Jean Delvare <jdelvare@suse.de>
Cc: Sergey Vlasov <vsu@altlinux.ru>,
	Nick Piggin <nickpiggin@yahoo.com.au>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Daniel Drake <dsd@reactivated.net>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Adrian Bunk <bunk@stusta.de>
Subject: Re: [PATCH] VIA IRQ quirk breakage fix
Date: Tue, 30 Jan 2007 18:37:06 -0800	[thread overview]
Message-ID: <20070130183706.f0d93103.akpm@osdl.org> (raw)
In-Reply-To: <200701301325.58843.jdelvare@suse.de>

On Tue, 30 Jan 2007 13:25:58 +0100
Jean Delvare <jdelvare@suse.de> wrote:

> So here comes the third
> (and hopefully last) iteration of the patch:

argh, it looks like I sent v2 to Linus.

Here's the missing bit.  Please confirm that we want it?


From: Jean Delvare <jdelvare@suse.de>

Add special handling for the VT82C686.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---

 drivers/pci/quirks.c |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff -puN drivers/pci/quirks.c~via-quirk-fix-update drivers/pci/quirks.c
--- a/drivers/pci/quirks.c~via-quirk-fix-update
+++ a/drivers/pci/quirks.c
@@ -661,9 +661,11 @@ static void quirk_via_bridge(struct pci_
 	/* See what bridge we have and find the device ranges */
 	switch (dev->device) {
 	case PCI_DEVICE_ID_VIA_82C686:
-		/* 82C686 is special */
-		via_vlink_dev_lo = 7;
-		via_vlink_dev_hi = 7;
+		/* The VT82C686 is special, it attaches to PCI and can have
+		   any device number. All its subdevices are functions of
+		   that single device. */
+		via_vlink_dev_lo = PCI_SLOT(dev->devfn);
+		via_vlink_dev_hi = PCI_SLOT(dev->devfn);
 		break;
 	case PCI_DEVICE_ID_VIA_8237:
 	case PCI_DEVICE_ID_VIA_8237A:
_


  parent reply	other threads:[~2007-01-31  2:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-24  0:33 via irq quirk breakage Nick Piggin
2007-01-29 15:00 ` Jean Delvare
2007-01-29 15:51   ` Alan
2007-01-30 12:29     ` Jean Delvare
2007-01-30 16:05       ` Alan
2007-01-30  2:35   ` Nick Piggin
2007-01-30  7:54     ` Jean Delvare
2007-01-30  8:32       ` Nick Piggin
2007-01-30 11:47       ` Sergey Vlasov
2007-01-30 12:25         ` [PATCH] VIA IRQ quirk breakage fix Jean Delvare
2007-01-30 13:38           ` Nick Piggin
2007-01-30 13:49             ` Jean Delvare
2007-01-30 16:21               ` Alan
2007-01-30 16:17                 ` Jean Delvare
2007-01-30 18:02               ` Andrew Morton
2007-01-31  2:37           ` Andrew Morton [this message]
2007-02-01  7:39             ` Jean Delvare
2007-01-30 14:56       ` via irq quirk breakage Alan
2007-01-30 14:50         ` Jeff Garzik
2007-01-30 14:25     ` Alan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070130183706.f0d93103.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bunk@stusta.de \
    --cc=dsd@reactivated.net \
    --cc=jdelvare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    --cc=vsu@altlinux.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox