public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan <alan@lxorguk.ukuu.org.uk>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: conke.hu@amd.com
Subject: Re: atiixp.c: add cable detection support for ATI IDE
Date: Tue, 30 Jan 2007 22:37:23 +0000	[thread overview]
Message-ID: <20070130223723.10d35b87@localhost.localdomain> (raw)
In-Reply-To: <200701301859.l0UIxaqX025758@hera.kernel.org>

>     IDE HDD does not work if it uses a 40-pin PATA cable on ATI chipset.
>     This patch fixes the bug.
>     
>     Signed-off-by: Conke Hu <conke.hu@amd.com>

Doe this actually work if the driver is loaded after a suspend to ram and
resume ?

> -	hwif->udma_four = 1;
> +	pci_read_config_byte(pdev, ATIIXP_IDE_UDMA_MODE + ch, &udma_mode);
> +	if ((udma_mode & 0x07) >= 0x04 || (udma_mode & 0x70) >= 0x40)
> +		hwif->udma_four = 1;
> +	else
> +		hwif->udma_four = 0;
> +

How does the actual cable detection work rather than relying on the BIOS
modes to guess the cable ?

Alan

           reply	other threads:[~2007-01-30 22:25 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <200701301859.l0UIxaqX025758@hera.kernel.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070130223723.10d35b87@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=conke.hu@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox