* Reducing warning output from pci_get_subsys()
@ 2007-01-31 4:55 Kumar Gala
2007-01-31 5:11 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Kumar Gala @ 2007-01-31 4:55 UTC (permalink / raw)
To: Greg KH; +Cc: linux-kernel, linux-pci
Greg,
There was some code added to warn if pci_get_subsys() is called and the
pci_devices is empty.
I'm wondering if there is some point at which we know its ok for the
pci_devices list be empty if there are no devices on the bus so we can
stop printing the message.
On an embedded PPC reference system I see this message 6 times when I've
got no cards in the PCI slots.
- k
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Reducing warning output from pci_get_subsys()
2007-01-31 4:55 Reducing warning output from pci_get_subsys() Kumar Gala
@ 2007-01-31 5:11 ` Andrew Morton
2007-01-31 5:18 ` Kumar Gala
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2007-01-31 5:11 UTC (permalink / raw)
To: Kumar Gala; +Cc: Greg KH, linux-kernel, linux-pci
On Tue, 30 Jan 2007 22:55:38 -0600 (CST)
Kumar Gala <galak@kernel.crashing.org> wrote:
> Greg,
>
> There was some code added to warn if pci_get_subsys() is called and the
> pci_devices is empty.
>
> I'm wondering if there is some point at which we know its ok for the
> pci_devices list be empty if there are no devices on the bus so we can
> stop printing the message.
>
> On an embedded PPC reference system I see this message 6 times when I've
> got no cards in the PCI slots.
>
I'd suggest we just remove the warning. Also the one in pci_find_subsys().
I let them go through because I was curious to know what would cause it to
trigger - it might be an indication of other bugs. But nothing very
interesting happened and they're of no use.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Reducing warning output from pci_get_subsys()
2007-01-31 5:11 ` Andrew Morton
@ 2007-01-31 5:18 ` Kumar Gala
2007-01-31 6:12 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Kumar Gala @ 2007-01-31 5:18 UTC (permalink / raw)
To: Andrew Morton; +Cc: Greg KH, linux-kernel, linux-pci
On Jan 30, 2007, at 11:11 PM, Andrew Morton wrote:
> On Tue, 30 Jan 2007 22:55:38 -0600 (CST)
> Kumar Gala <galak@kernel.crashing.org> wrote:
>
>> Greg,
>>
>> There was some code added to warn if pci_get_subsys() is called
>> and the
>> pci_devices is empty.
>>
>> I'm wondering if there is some point at which we know its ok for the
>> pci_devices list be empty if there are no devices on the bus so we
>> can
>> stop printing the message.
>>
>> On an embedded PPC reference system I see this message 6 times
>> when I've
>> got no cards in the PCI slots.
>>
>
> I'd suggest we just remove the warning. Also the one in
> pci_find_subsys().
>
> I let them go through because I was curious to know what would
> cause it to
> trigger - it might be an indication of other bugs. But nothing very
> interesting happened and they're of no use.
Works for me.
- k
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Reducing warning output from pci_get_subsys()
2007-01-31 5:18 ` Kumar Gala
@ 2007-01-31 6:12 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2007-01-31 6:12 UTC (permalink / raw)
To: Kumar Gala; +Cc: Andrew Morton, linux-kernel, linux-pci
On Tue, Jan 30, 2007 at 11:18:21PM -0600, Kumar Gala wrote:
>
> On Jan 30, 2007, at 11:11 PM, Andrew Morton wrote:
>
> >On Tue, 30 Jan 2007 22:55:38 -0600 (CST)
> >Kumar Gala <galak@kernel.crashing.org> wrote:
> >
> >>Greg,
> >>
> >>There was some code added to warn if pci_get_subsys() is called
> >>and the
> >>pci_devices is empty.
> >>
> >>I'm wondering if there is some point at which we know its ok for the
> >>pci_devices list be empty if there are no devices on the bus so we
> >>can
> >>stop printing the message.
> >>
> >>On an embedded PPC reference system I see this message 6 times
> >>when I've
> >>got no cards in the PCI slots.
> >>
> >
> >I'd suggest we just remove the warning. Also the one in
> >pci_find_subsys().
> >
> >I let them go through because I was curious to know what would
> >cause it to
> >trigger - it might be an indication of other bugs. But nothing very
> >interesting happened and they're of no use.
>
> Works for me.
No objection from me either.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-01-31 6:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-01-31 4:55 Reducing warning output from pci_get_subsys() Kumar Gala
2007-01-31 5:11 ` Andrew Morton
2007-01-31 5:18 ` Kumar Gala
2007-01-31 6:12 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox