From: Magnus Damm <magnus@valinux.co.jp>
To: linux-kernel@vger.kernel.org
Cc: akpm@osdl.org, jlan@sgi.com, nanhai.zou@intel.com,
magnus.damm@gmail.com, Magnus Damm <magnus@valinux.co.jp>,
horms@verge.net.au
Subject: [PATCH] kexec: Avoid migration of already disabled irqs (ia64)
Date: Thu, 01 Feb 2007 22:08:48 +0900 [thread overview]
Message-ID: <20070201130848.3785.12144.sendpatchset@localhost> (raw)
kexec: Avoid migration of already disabled irqs (ia64)
This patch fixes up ia64 kexec support for HP rx2620 hardware. It does this
by skipping migration of already disabled irqs. This is most likely a problem
on other ia64 platforms as well, but I've only been able to reproduce it on
one machine so far.
The full story is that handle_bad_irq() gets invoked before starting the new
kernel without this patch. This seems to happen when fixup_irqs() calls
generic_handle_irq() on already migrated (and disabled) irqs. So by avoiding
migration of disabled irqs we stay away of handle_bad_irq().
The code has been tested on three different ia64 machines, all with good
results. It is possible to trigger the same bug by offlining a processor
using echo 0 > /sys/devices/system/cpu/cpuX/online.
More detailed information is available in the following mail thread:
http://lists.osdl.org/pipermail/fastboot/2007-January/thread.html#5774
Signed-off-by: Magnus Damm <magnus@valinux.co.jp>
Acked-by: Simon Horman <horms@verge.net.au>
Acked-by: Zou, Nanhai <nanhai.zou@intel.com>
Acked-by: Jay Lan <jlan@sgi.com>
---
Tested using kexec-tools-testing 7792798a79b78a5d566f70c9f00237d050b01350
on HP rx2620 hardware.
Applies on top of 2.6.20-rc7.
arch/ia64/kernel/irq.c | 3 +++
1 file changed, 3 insertions(+)
--- 0001/arch/ia64/kernel/irq.c
+++ 0004/arch/ia64/kernel/irq.c 2007-01-30 12:35:10.000000000 +0900
@@ -122,6 +122,9 @@ static void migrate_irqs(void)
for (irq=0; irq < NR_IRQS; irq++) {
desc = irq_desc + irq;
+ if (desc->status == IRQ_DISABLED)
+ continue;
+
/*
* No handling for now.
* TBD: Implement a disable function so we can now
reply other threads:[~2007-02-01 13:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070201130848.3785.12144.sendpatchset@localhost \
--to=magnus@valinux.co.jp \
--cc=akpm@osdl.org \
--cc=horms@verge.net.au \
--cc=jlan@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=nanhai.zou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox