Re: [patch, fix build regression] kbuild: Kbuild.include avoid using spaces in call arguments

Andrew Morton
2007-02-08T04:30:57Z

On Wed, 7 Feb 2007 15:52:54 -0800 (PST) Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Thu, 8 Feb 2007, Roman Zippel wrote:
> >
> > Sorry, it needs more changes, the patch simply wasn't ready.
>
> One problem I find very problematic with all the Kbuild setup is that
> people tend to be very quiet about any build issues until they simply go
> in.
>
> Things don't "get ready" on their own. In other areas, people comment on
> why they don't like patches. In Kbuild, for some reason, we often seem to
> have this situation where people don't react at all.
>
> Sam is great about maintaining the kernel build stuff most of the time,
> but because it's clearly a "secondary" thing, there tends to be some
> periods when nothing happens. Which is problematic for me..
>
> So I end up in a situation where I just basically will apply the patches
> just becauseif I don't, nothing ever happens. The good news is that _once_
> I apply them, people will usually notice problems and send in fixes fairly
> quickly. But this particular email was NOT useful, for example. "needs
> more changes" is the epitome of a "not useful" comment.

Yes, kbuild is a bit of a problem at present.

I'm sitting on these:

search-a-little-harder-for-mkimage.patch
make-mkcompile_h-use-lang=c-and-lc_all=c-for-cc-v.patch
add-mailmap-for-proper-git-shortlog-output.patch
qconf-immediately-update-integer-and-string-values-in-xconfig-display-take-2.patch
qconf-relocate-search-command.patch
qconf-fix-showing-help-info-on-failed-search.patch
qconf-back-button-behaviour-normalization.patch
kbuild-remove-references-to-deprecated-prepare-all-target.patch
new-toplevel-target-headers_check_all.patch

But I'm not sure that anyone has reviewed them much.

I'll probably just push 'em and see what happens. They seem to work.