Re: [PATCH 9/11] Panic delay fix

Zachary Amsden
2007-02-14T21:53:11Z

Alan wrote:
>> ??? I fail to see the code bloat and also the fast paths. Which fast
>> paths use udelay?
>>
>
> IDE on several platforms has performance critical paths that use
> ndelay(400) or failing that udelay(1)

Ok, I buy that. A 486DX / 33 Mhz processor takes 10 cycles to issue a
CALL / RET pair. This is about 300ns. Is there an issue with being too
early to issue I/O operations or too late?

If it is too early, then we have lost 10 cycles of processor time per
udelay, which considering the antiquity of this piece of hardware, seems
acceptable.

If it is too late, then there could be a real issue on older machines.
But I fail to see how such careful timing can be done at this
granularity on such hardware without well tweaked assembly code. A
suboptimal compile output could easily throw you off by just as much,
sticking a little bit of arithmetic before and after the delay.

Zach