Re: [PATCH 9/11] Panic delay fix

Zachary Amsden
2007-02-08T21:26:34Z

Dmitry Torokhov wrote:
>
> However I am not really fond of idea of adding constructs like this
> all over the code:
>
> #define USE_REAL_TIME_DELAY_I_REALLY_MEAN_IT_THIS_TIME_I_SWEAR
>
> as the time passes... Drivers should be blissfully ignorant of being
> run on virtual hardware.

I agree in general, but there are two uses for this ugly construct. One
is for drivers and isolated sections of code which actually interact
with the real world. They need real time delays. The only two examples
so far are SMP coprocessor bootstrapping and blinking LEDs with a
recognizable frequency. I don't expect many more to show up.

The other use for this construct is compiling a hardware privileged
virtual domain that actually drives real hardware - you can just define
this globally to override any delay masking.

Zach