From: Andi Kleen <ak@suse.de>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
clameter@sgi.com, Andrew Morton <akpm@osdl.org>,
GOTO <y-goto@jp.fujitsu.com>
Subject: Re: [BUG][PATCH] fix mempolcy's check on a system with memory-less-node take2
Date: Thu, 8 Feb 2007 08:49:41 +0100 [thread overview]
Message-ID: <200702080849.42167.ak@suse.de> (raw)
In-Reply-To: <20070208110606.ebf668d3.kamezawa.hiroyu@jp.fujitsu.com>
> This panic(hang) was found by a numa test-set on a system with 3 nodes, where
> node(2) was memory-less-node.
I still think it's the wrong fix -- just get rid of the memory less node.
I expect you'll likely run into more problems with that setup anyways.
> static struct mempolicy *mpol_new(int mode, nodemask_t *nodes)
> {
> struct mempolicy *policy;
> + void *val;
Using void * here is nasty when it's a zonelist pointer.
-Andi
next prev parent reply other threads:[~2007-02-08 7:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-08 2:06 [BUG][PATCH] fix mempolcy's check on a system with memory-less-node take2 KAMEZAWA Hiroyuki
2007-02-08 7:49 ` Andi Kleen [this message]
2007-02-08 8:00 ` Andrew Morton
2007-02-08 8:03 ` Andi Kleen
2007-02-08 8:08 ` Andrew Morton
2007-02-08 8:19 ` Andi Kleen
2007-02-08 8:24 ` Andrew Morton
2007-02-08 8:16 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702080849.42167.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox