From: Alan <alan@lxorguk.ukuu.org.uk>
To: Robert Hancock <hancockr@shaw.ca>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, jeff@garzik.org
Subject: Re: [PATCH] pata_acpi: take two
Date: Fri, 9 Feb 2007 20:18:07 +0000 [thread overview]
Message-ID: <20070209201807.57e727a4@localhost.localdomain> (raw)
In-Reply-To: <45CAB125.7000907@shaw.ca>
> > +#if defined(CONFIG_ATA_ACPI)
> > + /* Prefer the ACPI driver for Nvidia hardware */
> > + if (pdev->vendor == PCI_VENDOR_ID_NVIDIA && ata_pata_acpi_present(pdev))
> > + return -ENODEV;
> > +#endif
> > /* Check for AMD7411 */
> > if (type == 3)
> > /* FIFO is broken */
>
> Problem with this approach is it may break distro/initrd setups since
> the pata_amd driver appears to be the one that "should" work based on
> the PCI ID, so the initrd would end up containing only this driver,
Diddums
> which will fail out with -ENODEV and cause a boot failure. If the root
> filesystem was on a disk driven by this controller, the mkinitrd stuff
> would have to "know" that it should also try loading pata_acpi.
Indeed they will.
> Unless there are some Nvidia boxes out there which don't provide
> _GTM/_STM ACPI methods (which seems a bit unlikely given Allen Martin's
> comments) then we could potentially move the Nvidia PATA PCI IDs into
> the pata_acpi driver, at least if ACPI is enabled in the kernel build..
No we can't. It is a dynamic evaluation. The user may be booting with
acpi=off to work around BIOS problems, so the distribution initrd tools
will just have to learn this out as they do the sata_nv funnies. (Nvidia
is already a special case)
next prev parent reply other threads:[~2007-02-09 20:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa.E0XxdpTYuPtTLgPLQYHs2V10jM4@ifi.uio.no>
2007-02-08 5:12 ` [PATCH] pata_acpi: take two Robert Hancock
2007-02-09 20:18 ` Alan [this message]
2007-02-07 17:22 Alan
2007-02-07 20:38 ` Mariusz Kozlowski
2007-02-08 0:30 ` Andrew Morton
2007-02-09 20:13 ` Alan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070209201807.57e727a4@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=hancockr@shaw.ca \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox