From: Pavel Machek <pavel@ucw.cz>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Nigel Cunningham <nigel@nigel.suspend2.net>,
Otavio Salvador <otavio@debian.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Add PM_TRACE x86_64 support.
Date: Fri, 9 Feb 2007 22:52:55 +0000 [thread overview]
Message-ID: <20070209225255.GC3949@ucw.cz> (raw)
In-Reply-To: <20070208124003.GE4487@kernel.dk>
Hi!
> > > Nigel Cunningham <nigel@nigel.suspend2.net> writes:
> > >
> > > > - for (tracedata = &__tracedata_start ; tracedata < &__tracedata_end ; tracedata += 6) {
> > > > + for (tracedata = &__tracedata_start ; tracedata < &__tracedata_end ; tracedata += 2 + sizeof(unsigned long)) {
> > >
> > > Could you split this line?
> >
> > Sure.
> >
> > -- New version -- (What's the right way to do this?)
> >
> > This patch add x86_64 support for PM_TRACE, and shifts per-arch code to
> > the appropriate subdirectories.
> >
> > Symbol exports are added so tracing can be used from drivers built as
> > modules too.
>
> Don't include exports in a patch that doesn't use them. Introduce the
> exports in a later patch series, for when you actually need it.
It is debugging infrastructure, so export actually makes sense... It
will not ever be used in mainline kernel; you need to modify code
manually to use this code..
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2007-02-09 23:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-08 0:50 [PATCH] Add PM_TRACE x86_64 support Nigel Cunningham
2007-02-08 1:18 ` Otavio Salvador
2007-02-08 2:08 ` Nigel Cunningham
2007-02-08 12:40 ` Jens Axboe
2007-02-09 22:52 ` Pavel Machek [this message]
2007-02-10 8:42 ` Jens Axboe
2007-02-13 21:35 ` Pavel Machek
2007-02-15 12:01 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070209225255.GC3949@ucw.cz \
--to=pavel@ucw.cz \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nigel@nigel.suspend2.net \
--cc=otavio@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox