Re: current git breaks resume

Alexey Starikovskiy
2007-02-11T14:34:32Z

[-- Attachment #1: Type: text/plain, Size: 677 bytes --]

Len Brown wrote:
> On Friday 09 February 2007 14:03, Jens Axboe wrote:
>
>> Hi,
>>
>> Unfortunately I'm a little short on time as I'll be travelling tomorrow,
>> but of course preparing a new kernel for the laptop is something you
>> want to do right before leaving. So I discovered that the current (well
>> as of yesterday, HEAD is 5986a2ec35836a878350c54af4bd91b1de6abc59)
>> doesn't resume on my x60. 2.6.20 works fine, so something broke since
>> then.
>>
>
> resume from RAM, or resume from disk?
>
>
Len,
resume from RAM is still broken by "Disable all wakeup GPEs". My
previous patch for T43 does not help, only attached one helps (revert
original patch).

[-- Attachment #2: fix-disable_all_wake_gpes.patch --]
[-- Type: text/plain, Size: 1049 bytes --]

Disable wake GPEs only once.

From: Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>

---

drivers/acpi/events/evgpe.c | 11 -----------
1 files changed, 0 insertions(+), 11 deletions(-)

diff --git a/drivers/acpi/events/evgpe.c b/drivers/acpi/events/evgpe.c
index dfac3ec..635ba44 100644
--- a/drivers/acpi/events/evgpe.c
+++ b/drivers/acpi/events/evgpe.c
@@ -636,17 +636,6 @@ acpi_ev_gpe_dispatch(struct acpi_gpe_eve
}
}

- if (!acpi_gbl_system_awake_and_running) {
- /*
- * We just woke up because of a wake GPE. Disable any further GPEs
- * until we are fully up and running (Only wake GPEs should be enabled
- * at this time, but we just brute-force disable them all.)
- * 1) We must disable this particular wake GPE so it won't fire again
- * 2) We want to disable all wake GPEs, since we are now awake
- */
- (void)acpi_hw_disable_all_gpes();
- }
-
/*
* Dispatch the GPE to either an installed handler, or the control method
* associated with this GPE (_Lxx or _Exx). If a handler exists, we invoke