From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Srinivasa Ds <srinivasa@in.ibm.com>,
Frederik Deweerdt <deweerdt@free.fr>,
Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
jkenisto@us.ibm.com, anil.s.keshavamurthy@intel.com,
prasanna@in.ibm.com, davem@davemloft.net
Subject: Re: [RFC] [PATCH] To list all active probes in the system---Take-2
Date: Mon, 12 Feb 2007 14:59:45 +0530 [thread overview]
Message-ID: <20070212092945.GA7109@in.ibm.com> (raw)
In-Reply-To: <20070212004515.b66ec836.akpm@linux-foundation.org>
On Mon, Feb 12, 2007 at 12:45:15AM -0800, Andrew Morton wrote:
> On Thu, 08 Feb 2007 17:16:15 +0530 Srinivasa Ds <srinivasa@in.ibm.com> wrote:
>
> > + if (p->pre_handler == pre_handler_kretprobe)
>
> This breaks on sparc64:
>
> kernel/kprobes.c: In function `report_probe':
> kernel/kprobes.c:826: error: `pre_handler_kretprobe' undeclared (first use in this function)
Andrew,
Here is a patch to fix the issue, compile tested with crosstools. Sorry for
the trouble.
Do you want a comprehensive patch that folds all the related changes
into one?
Ananth
--
Fix kprobes compilation breakage on sparc64 caused due to
kprobes-list-all-active-probes-in-the-system.patch
Signed-off-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
---
kernel/kprobes.c | 6 ++++++
1 files changed, 6 insertions(+)
Index: linux-2.6.20/kernel/kprobes.c
===================================================================
--- linux-2.6.20.orig/kernel/kprobes.c
+++ linux-2.6.20/kernel/kprobes.c
@@ -780,6 +780,12 @@ int __kprobes register_kretprobe(struct
return -ENOSYS;
}
+static int __kprobes pre_handler_kretprobe(struct kprobe *p,
+ struct pt_regs *regs)
+{
+ return 0;
+}
+
#endif /* ARCH_SUPPORTS_KRETPROBES */
void __kprobes unregister_kretprobe(struct kretprobe *rp)
next prev parent reply other threads:[~2007-02-12 9:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-06 9:55 [RFC] [PATCH] To list all active probes in the system Srinivasa Ds
2007-02-06 10:06 ` Christoph Hellwig
2007-02-06 10:22 ` Srinivasa Ds
2007-02-06 14:47 ` Srinivasa Ds
2007-02-06 14:56 ` Frederik Deweerdt
2007-02-07 5:25 ` Srinivasa Ds
2007-02-07 22:27 ` Andrew Morton
2007-02-08 11:46 ` [RFC] [PATCH] To list all active probes in the system---Take-2 Srinivasa Ds
2007-02-09 8:03 ` Andrew Morton
2007-02-12 8:45 ` Andrew Morton
2007-02-12 9:29 ` Ananth N Mavinakayanahalli [this message]
2007-02-06 10:13 ` [RFC] [PATCH] To list all active probes in the system Andrew Morton
2007-02-06 10:21 ` Srinivasa Ds
2007-02-06 20:36 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070212092945.GA7109@in.ibm.com \
--to=ananth@in.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=davem@davemloft.net \
--cc=deweerdt@free.fr \
--cc=hch@infradead.org \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=prasanna@in.ibm.com \
--cc=srinivasa@in.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox