From: Andrew Morton <akpm@linux-foundation.org>
To: Blaisorblade <blaisorblade@yahoo.it>
Cc: user-mode-linux-devel@lists.sourceforge.net,
Jeff Dike <jdike@addtoit.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@suse.de>,
stable@kernel.org
Subject: Re: [uml-devel] x86_64: fix 2.6.18 regression - PTRACE_OLDSETOPTIONS should be accepted
Date: Wed, 14 Feb 2007 21:51:23 -0800 [thread overview]
Message-ID: <20070214215123.57ef2d4a.akpm@linux-foundation.org> (raw)
In-Reply-To: <200702150443.42287.blaisorblade@yahoo.it>
On Thu, 15 Feb 2007 04:43:41 +0100 Blaisorblade <blaisorblade@yahoo.it> wrote:
> > I sent an equivalent patch in earlier today:
> Doh! Interesting this timing...
>
> > Index: linux-2.6/arch/x86_64/ia32/ptrace32.c
> > ===================================================================
> > --- linux-2.6.orig/arch/x86_64/ia32/ptrace32.c
> > +++ linux-2.6/arch/x86_64/ia32/ptrace32.c
> > @@ -239,6 +239,8 @@ asmlinkage long sys32_ptrace(long reques
> > __u32 val;
> >
> > switch (request) {
> > + case PTRACE_OLDSETOPTIONS:
> > + request = PTRACE_SETOPTIONS;
> > case PTRACE_TRACEME:
> > case PTRACE_ATTACH:
> > case PTRACE_KILL:
> >
> > I change the request so that PTRACE_OLDSETOPTIONS doesn't need to
> > propogate any further. However, it is present in include/asm-x86_64,
> > so I guess that counts as being part of the x86_64 ABI. That being
> > the case, I guess my patch can be dropped in favor of this one.
>
> It is handled in ptrace_request, unless there are include problems. I'm going
> to reboot and test mine for any remaining problem.
Whatever happens, please ensure that the final fix makes it into -stable
as well. Jeff's version of this patch wasn't cc'ed to stable@kernel.org.
next prev parent reply other threads:[~2007-02-15 5:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-15 2:34 x86_64: fix 2.6.18 regression - PTRACE_OLDSETOPTIONS should be accepted Paolo 'Blaisorblade' Giarrusso
2007-02-15 2:54 ` Jeff Dike
2007-02-15 3:43 ` [uml-devel] " Blaisorblade
2007-02-15 5:51 ` Andrew Morton [this message]
2007-02-15 17:01 ` Jeff Dike
2007-02-15 19:05 ` Blaisorblade
2007-02-16 19:02 ` Jeff Dike
2007-02-17 0:04 ` Blaisorblade
2007-02-17 0:38 ` Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070214215123.57ef2d4a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@suse.de \
--cc=blaisorblade@yahoo.it \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox