Re: [patch 07/21] Xen-paravirt: remove ctor for pgd cache

Nick Piggin
2007-02-16T09:20:31Z

Pekka Enberg wrote:
> On 2/16/07, Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
>> Remove the ctor for the pgd cache. There's no point in having the
>> cache machinery do this via an indirect call when all pgd are freed in
>> the one place anyway.
>
>
> The reason we have slab constructors and destructors is to _avoid_
> reinitializing every time we allocate an object. AFAICT your changing
> the code now to do _more_ work than before, so is there some other
> reason why you want to do this than avoiding an indirect call?

Sometimes it is better for the caches to initialise an object
immediately, but in this case I think it is better to use the
slab ctor because it is very unlikely to use many cachelines
immediately anyway.

It would be nice to put the "why" in the changelogs, rather than
"what". Not everyone wants to go through the whole patchset to
decipher why Xen possibly needs something.

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com