Re: [patch 04/21] Xen-paravirt: ===================================================================

Jeremy Fitzhardinge
2007-02-16T17:32:46Z

Andi Kleen wrote:
> Subject? description?
>
>
> On Thu, Feb 15, 2007 at 06:24:53PM -0800, Jeremy Fitzhardinge wrote:
>
>> -static void vmi_set_pte_present(struct mm_struct *mm, unsigned long addr, pte_t *ptep, pte_t pte)
>> +static void vmi_set_pte_present(struct mm_struct *mm, u32 addr, pte_t *ptep, pte_t pte)
>>
>
> And what good is that change anyways? unsigned long is the usual style
> for addresses.
There was a fair amount of inconsistency. In this case, u32 was being
used for existing functions dealing with addresses, and I propagated it
through. I can switch it all back to unsigned long if you'd prefer.

J