Re: Subject: [PATCH 2.6.20 004/005] dmfe: Add support for suspend/resume

Pavel Machek
2007-02-17T22:52:35Z

Hi!
>
> Hello , I am sorry that I missed some parts of coding style. I need to reread it :-)
>
> There is a updated patch :

It looks better.

> + /* Disable Interrupt */
> + outl (0, dev->base_addr + DCR7);
> + outl (inl(dev->base_addr + DCR5), dev->base_addr + DCR5);

I'd kill space after outl...

> + /* Free RX buffers */
> + dmfe_free_rxbuffer(db);
> +
> + /* Power down device*/

and add space before */.

Congratulation, you passed coding-style-police-check ;-).
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html