Re: [PATCH] sparse chokes on arch/i386/kernel/i8253.c

[Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>]

* Andrew Morton (akpm@linux-foundation.org) wrote:
> On Thu, 15 Feb 2007 19:23:47 -0500
> Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:
> 
> > sparse chokes on arch/i386/kernel/i8253.c
> > 
> > Here is a marker fix that puts the correct -i include/linux/marker.h in
> > the top level Makefile so sparse works correctly. The tricky part is to
> > keep the kernel compiling correctly with a kernel build directory
> > different from the kernel source tree too.
> > 
> > The fix applies on top the the Linux Kernel Markers for 2.6.20.
> > 
> > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
> > 
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -309,7 +309,8 @@ AFLAGS_KERNEL	=
> >  LINUXINCLUDE    := -Iinclude \
> >                     $(if $(KBUILD_SRC),-Iinclude2 -I$(srctree)/include) \
> >  		   -include include/linux/autoconf.h \
> > -		   -include linux/marker.h
> > +		   -include \
> > +		   	$(if $(KBUILD_SRC),$(srctree)/)include/linux/marker.h
> >  
> >  CPPFLAGS        := -D__KERNEL__ $(LINUXINCLUDE)
> 
> But what is so magical about marker.h to justify special-case treatment at the
> kbuid level?

Idealistically speaking, nothing. It is however much easier to maintain
an external set of patches introducing markers within the kernel tree :
most of the rejects between kernel version comes from new includes that
comes in the way.

So this is there more by convenience than requirement.

Mathieu

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Candidate, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68