From: Artem Bityutskiy <dedekind@infradead.org>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Artem Bityutskiy <dedekind@infradead.org>,
Frank Haverkamp <haver@vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
David Woodhouse <dwmw2@infradead.org>,
Josh Boyer <jwboyer@linux.vnet.ibm.com>
Subject: [PATCH 32/44 take 2] [UBI] accounting unit implementation
Date: Sat, 17 Feb 2007 18:57:05 +0200 [thread overview]
Message-ID: <20070217165705.5845.13508.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20070217165424.5845.4390.sendpatchset@localhost.localdomain>
diff -auNrp tmp-from/drivers/mtd/ubi/account.c tmp-to/drivers/mtd/ubi/account.c
--- tmp-from/drivers/mtd/ubi/account.c 1970-01-01 02:00:00.000000000 +0200
+++ tmp-to/drivers/mtd/ubi/account.c 2007-02-17 18:07:27.000000000 +0200
@@ -0,0 +1,286 @@
+/*
+ * Copyright (c) International Business Machines Corp., 2006
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
+ * the GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Author: Artem B. Bityutskiy
+ */
+
+#include <linux/sched.h>
+#include <linux/string.h>
+#include <linux/spinlock.h>
+#include <linux/err.h>
+#include <linux/types.h>
+#include <mtd/ubi-header.h>
+#include "ubi.h"
+#include "vtbl.h"
+#include "account.h"
+#include "scan.h"
+#include "alloc.h"
+#include "badeb.h"
+#include "io.h"
+#include "debug.h"
+
+int ubi_acc_mkvol(const struct ubi_info *ubi, int reserved_pebs)
+{
+ struct ubi_acc_info *acc = ubi->acc;
+
+ dbg_acc("reserve %d PEBs for a new volume (uvol_count %d"
+ "rsvd_pebs %d, avail_pebs %d)", reserved_pebs,
+ acc->uvol_count, acc->rsvd_pebs, acc->avail_pebs);
+ ubi_assert(reserved_pebs > 0);
+
+ spin_lock(&acc->lock);
+ if (acc->uvol_count + 1 > acc->max_volumes) {
+ dbg_err("no room for the volume");
+ goto out;
+ }
+ if (reserved_pebs > acc->avail_pebs) {
+ dbg_err("no enough PEBs");
+ goto out;
+ }
+ acc->uvol_count += 1;
+ acc->avail_pebs -= reserved_pebs;
+ acc->rsvd_pebs += reserved_pebs;
+ ubi_assert(acc->avail_pebs >= 0);
+ spin_unlock(&acc->lock);
+ return 0;
+
+out:
+ spin_unlock(&acc->lock);
+ return -ENOSPC;
+}
+
+void ubi_acc_rmvol(const struct ubi_info *ubi, int reserved_pebs)
+{
+ struct ubi_acc_info *acc = ubi->acc;
+
+ dbg_acc("remove volume and get back %d PEBs (uvol_count %d, "
+ "rsvd_pebs %d, avail_pebs %d)", reserved_pebs,
+ acc->uvol_count, acc->rsvd_pebs, acc->avail_pebs);
+ ubi_assert(reserved_pebs > 0 && reserved_pebs <= acc->rsvd_pebs);
+
+ spin_lock(&acc->lock);
+ acc->uvol_count -= 1;
+ acc->avail_pebs += reserved_pebs;
+ acc->rsvd_pebs -= reserved_pebs;
+ ubi_assert(acc->uvol_count >= 0);
+ ubi_assert(acc->rsvd_pebs >= 0);
+ spin_unlock(&acc->lock);
+
+ /* Take care about PEBs reserved for bad PEB handling */
+ ubi_beb_maintain_reserved(ubi);
+}
+
+int ubi_acc_reserve(const struct ubi_info *ubi, int pebs)
+{
+ struct ubi_acc_info *acc = ubi->acc;
+
+ dbg_acc("reserve %d PEBs (rsvd_pebs %d, avail_pebs %d)",
+ pebs, acc->rsvd_pebs, acc->avail_pebs);
+ ubi_assert(pebs > 0);
+
+ spin_lock(&acc->lock);
+ if (unlikely(pebs > acc->avail_pebs)) {
+ dbg_err("no enough PEBs");
+ spin_unlock(&acc->lock);
+ return -ENOSPC;
+ }
+ acc->avail_pebs -= pebs;
+ acc->rsvd_pebs += pebs;
+ spin_unlock(&acc->lock);
+ return 0;
+}
+
+void ubi_acc_free(const struct ubi_info *ubi, int pebs)
+{
+ struct ubi_acc_info *acc = ubi->acc;
+
+ dbg_acc("free %d PEBs (rsvd_pebs %d, avail_pebs %d)",
+ pebs, acc->rsvd_pebs, acc->avail_pebs);
+ spin_lock(&acc->lock);
+ ubi_assert(pebs > 0 && pebs <= acc->rsvd_pebs);
+ acc->rsvd_pebs -= pebs;
+ acc->avail_pebs += pebs;
+ spin_unlock(&acc->lock);
+}
+
+static int acc_info_check(const struct ubi_info *ubi,
+ const struct ubi_scan_info *si);
+
+int ubi_acc_init_scan(struct ubi_info *ubi, struct ubi_scan_info *si)
+{
+ int err, i;
+ struct ubi_acc_info *acc;
+ const struct ubi_vtbl_vtr *vtr;
+ const struct ubi_vtbl_info *vtbl = ubi->vtbl;
+ const struct ubi_io_info *io = ubi->io;
+
+ dbg_acc("initialize the accounting unit");
+
+ acc = ubi_kzalloc(sizeof(struct ubi_acc_info));
+ if (!acc)
+ return -ENOMEM;
+ ubi->acc = acc;
+
+ spin_lock_init(&acc->lock);
+ acc->ivol_count = UBI_INT_VOL_COUNT;
+
+ for (i = 0; i < acc->ivol_count; i++) {
+ cond_resched();
+ vtr = ubi_vtbl_get_vtr(ubi, UBI_INTERNAL_VOL_START + i);
+ ubi_assert(!IS_ERR(vtr));
+ acc->rsvd_pebs += vtr->reserved_pebs;
+ }
+
+ /*
+ * The maximum number of volumes may be less then the volume table
+ * fits if there are too few available eraseblocks on the flash.
+ */
+ acc->max_volumes = vtbl->vt_slots;
+ i = io->good_peb_count - acc->rsvd_pebs;
+ if (i <= 0) {
+ ubi_err("too small flash, at least %d good physical eraseblock"
+ " needed", acc->rsvd_pebs + 1);
+ err = -EINVAL;
+ goto out_acc;
+ }
+
+ if (acc->max_volumes > i)
+ acc->max_volumes = i;
+
+ for (i = 0; i < acc->max_volumes; i++) {
+ cond_resched();
+ vtr = ubi_vtbl_get_vtr(ubi, i);
+ if (IS_ERR(vtr))
+ continue;
+ acc->uvol_count += 1;
+ acc->rsvd_pebs += vtr->reserved_pebs;
+ }
+
+ acc->rsvd_pebs += si->alien_peb_count;
+ acc->avail_pebs = io->good_peb_count - acc->rsvd_pebs;
+
+ /* Check accounting information sanity and consistency */
+ err = acc_info_check(ubi, si);
+ if (err)
+ goto out_acc;
+
+ dbg_acc("uvol_count %d, ivol_count %d, avail_pebs %d rsvd_pebs %d "
+ "max_volumes %d", acc->uvol_count, acc->ivol_count,
+ acc->avail_pebs, acc->rsvd_pebs, acc->max_volumes);
+ return 0;
+
+out_acc:
+ ubi_kfree(acc);
+ return err;
+}
+
+void ubi_acc_close(const struct ubi_info *ubi)
+{
+ dbg_acc("close the accounting unit");
+ ubi_kfree(ubi->acc);
+}
+
+/**
+ * acc_info_check - check sanity and consistency of accounting information.
+ *
+ * @ubi: the UBI device description object
+ * @si: a pointer to the scanning information which must be consistent to accounting
+ * information
+ *
+ * As we try not to trust the data we read from the flash media, we have to
+ * check that the accounting information is sane and consistent, as it is
+ * formed using on-flash information. This function returns zero if all is fine
+ * and a negative error code if some inconsistency was found.
+ */
+static int acc_info_check(const struct ubi_info *ubi,
+ const struct ubi_scan_info *si)
+{
+ int i;
+ const struct ubi_vtbl_vtr *vtr;
+ const struct ubi_acc_info *acc = ubi->acc;
+ const struct ubi_vtbl_info *vtbl = ubi->vtbl;
+ const struct ubi_io_info *io = ubi->io;
+
+ if (acc->avail_pebs < 0 || acc->rsvd_pebs < 0 || acc->uvol_count < 0 ||
+ acc->ivol_count < 0) {
+ dbg_err("negative values");
+ goto bad;
+ }
+
+ if (acc->avail_pebs > io->good_peb_count) {
+ dbg_err("bad avail_pebs");
+ goto bad;
+ }
+
+ if (acc->rsvd_pebs > io->good_peb_count) {
+ dbg_err("bad rsvd_pebs");
+ goto bad;
+ }
+
+ if (acc->avail_pebs + acc->rsvd_pebs != io->good_peb_count) {
+ dbg_err("accounting error");
+ goto bad;
+ }
+
+ if (acc->max_volumes > vtbl->vt_slots) {
+ dbg_err("bad max_volumes");
+ goto bad;
+ }
+
+ if (acc->ivol_count + acc->uvol_count > acc->max_volumes) {
+ dbg_err("vol. count (%d + %d) > max_volumes",
+ acc->ivol_count, acc->uvol_count);
+ goto bad;
+ }
+
+ /*
+ * Ensure that there are no volumes which exceed acc->max_volumes
+ * exist.
+ */
+ for (i = acc->max_volumes; i < vtbl->vt_slots; i++) {
+ cond_resched();
+ vtr = ubi_vtbl_get_vtr(ubi, i);
+ if (unlikely(!IS_ERR(vtr))) {
+ dbg_err("volume %d exists", i);
+ goto bad;
+ }
+ }
+
+ if (si->vols_found > acc->ivol_count + acc->uvol_count) {
+ dbg_err("scanning found volumes %d > %d + %d",
+ si->vols_found, acc->ivol_count, acc->uvol_count);
+ goto bad;
+ }
+
+ if (si->highest_vol_id >= acc->max_volumes &&
+ si->highest_vol_id < UBI_INTERNAL_VOL_START) {
+ dbg_err("too large volume ID %d found by scanning",
+ si->highest_vol_id);
+ goto bad;
+ }
+
+ return 0;
+
+bad:
+ ubi_err("accounting check failed");
+ dbg_err("uvol_count %d, ivol_count %d, avail_pebs %d, rsvd_pebs %d "
+ "io->good_peb_count %d, max_volumes %d, vtbl->vt_slots %d",
+ acc->uvol_count, acc->ivol_count, acc->avail_pebs,
+ acc->rsvd_pebs, io->good_peb_count, acc->max_volumes,
+ vtbl->vt_slots);
+ return -EINVAL;
+}
next prev parent reply other threads:[~2007-02-17 17:13 UTC|newest]
Thread overview: 129+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-17 16:54 [PATCH 00/44 take 2] [UBI] Unsorted Block Images Artem Bityutskiy
2007-02-17 16:54 ` [PATCH 01/44 take 2] [UBI] Linux build integration Artem Bityutskiy
2007-02-17 16:54 ` [PATCH 02/44 take 2] [UBI] on-flash data structures header Artem Bityutskiy
2007-02-17 16:54 ` [PATCH 03/44 take 2] [UBI] user-space API header Artem Bityutskiy
2007-02-17 21:27 ` Arnd Bergmann
2007-02-20 13:07 ` Artem Bityutskiy
2007-02-20 13:17 ` Arnd Bergmann
2007-02-17 16:54 ` [PATCH 04/44 take 2] [UBI] kernel-spce " Artem Bityutskiy
2007-02-18 1:32 ` Greg KH
2007-02-18 2:08 ` Josh Boyer
2007-02-26 12:12 ` Artem Bityutskiy
2007-02-17 16:54 ` [PATCH 05/44 take 2] [UBI] internal common header Artem Bityutskiy
2007-02-17 21:05 ` Arnd Bergmann
2007-02-19 11:16 ` Artem Bityutskiy
2007-02-19 10:54 ` Christoph Hellwig
2007-02-19 12:38 ` Josh Boyer
2007-02-20 13:05 ` Artem Bityutskiy
2007-02-20 14:55 ` Theodore Tso
2007-02-20 15:15 ` David Woodhouse
2007-02-20 15:22 ` Theodore Tso
2007-02-20 15:33 ` David Woodhouse
2007-02-20 16:12 ` Theodore Tso
2007-02-20 16:47 ` David Woodhouse
2007-02-25 10:42 ` Pavel Machek
2007-02-20 15:24 ` Artem Bityutskiy
2007-02-25 5:45 ` Christoph Hellwig
2007-02-26 10:28 ` Artem Bityutskiy
2007-02-25 5:43 ` Christoph Hellwig
2007-02-25 6:04 ` David Woodhouse
2007-02-20 15:21 ` Artem Bityutskiy
2007-02-25 5:46 ` Christoph Hellwig
2007-02-20 15:25 ` Artem Bityutskiy
2007-02-25 5:50 ` Christoph Hellwig
2007-02-25 11:55 ` Theodore Tso
2007-02-26 10:09 ` Artem Bityutskiy
2007-02-17 16:54 ` [PATCH 06/44 take 2] [UBI] startup code Artem Bityutskiy
2007-02-19 10:59 ` Christoph Hellwig
2007-02-20 13:00 ` Artem Bityutskiy
2007-02-23 11:03 ` Artem Bityutskiy
2007-02-25 5:58 ` Christoph Hellwig
2007-02-25 22:03 ` Rusty Russell
2007-03-05 13:28 ` Frank Haverkamp
2007-02-26 11:54 ` Artem Bityutskiy
2007-05-17 14:44 ` Christoph Hellwig
2007-05-17 15:06 ` Artem Bityutskiy
2007-02-17 16:54 ` [PATCH 07/44 take 2] [UBI] misc unit header Artem Bityutskiy
2007-02-17 22:59 ` Theodore Tso
2007-02-19 11:00 ` Christoph Hellwig
2007-02-20 12:56 ` Artem Bityutskiy
2007-02-19 11:13 ` Artem Bityutskiy
2007-02-17 16:55 ` [PATCH 08/44 take 2] [UBI] misc unit implementation Artem Bityutskiy
2007-02-17 16:55 ` [PATCH 09/44 take 2] [UBI] debug unit header Artem Bityutskiy
2007-02-17 21:18 ` Arnd Bergmann
2007-02-19 11:00 ` Christoph Hellwig
2007-02-19 12:33 ` Artem Bityutskiy
2007-02-19 14:02 ` Josh Boyer
2007-02-19 14:04 ` Artem Bityutskiy
2007-02-17 16:55 ` [PATCH 10/44 take 2] [UBI] debug unit implementation Artem Bityutskiy
2007-02-17 21:00 ` Arnd Bergmann
2007-02-19 12:29 ` Artem Bityutskiy
2007-02-17 16:55 ` [PATCH 11/44 take 2] [UBI] allocation unit header Artem Bityutskiy
2007-02-17 16:55 ` [PATCH 12/44 take 2] [UBI] allocation unit implementation Artem Bityutskiy
2007-02-17 20:55 ` Arnd Bergmann
2007-02-19 11:05 ` Artem Bityutskiy
2007-02-19 11:13 ` Pekka Enberg
2007-02-20 11:30 ` Artem Bityutskiy
2007-02-17 16:55 ` [PATCH 13/44 take 2] [UBI] I/O unit header Artem Bityutskiy
2007-02-17 16:55 ` [PATCH 14/44 take 2] [UBI] I/O unit implementation Artem Bityutskiy
2007-02-17 16:55 ` [PATCH 15/44 take 2] [UBI] scanning unit header Artem Bityutskiy
2007-02-17 23:07 ` Theodore Tso
2007-02-18 2:17 ` Josh Boyer
2007-02-17 16:55 ` [PATCH 16/44 take 2] [UBI] scanning unit implementation Artem Bityutskiy
2007-02-19 11:05 ` Christoph Hellwig
2007-02-19 14:11 ` Artem Bityutskiy
2007-02-17 16:55 ` [PATCH 17/44 take 2] [UBI] build unit header Artem Bityutskiy
2007-02-17 16:55 ` [PATCH 18/44 take 2] [UBI] build unit implementation Artem Bityutskiy
2007-02-17 16:56 ` [PATCH 19/44 take 2] [UBI] volume table unit header Artem Bityutskiy
2007-02-17 16:56 ` [PATCH 20/44 take 2] [UBI] volume table unit implementation Artem Bityutskiy
2007-02-17 16:56 ` [PATCH 21/44 take 2] [UBI] background thread unit header Artem Bityutskiy
2007-02-17 16:56 ` [PATCH 22/44 take 2] [UBI] background thread unit implementation Artem Bityutskiy
2007-02-19 11:09 ` Christoph Hellwig
2007-02-19 13:55 ` Artem Bityutskiy
2007-02-17 16:56 ` [PATCH 23/44 take 2] [UBI] wear-leveling unit header Artem Bityutskiy
2007-02-17 16:56 ` [PATCH 24/44 take 2] [UBI] wear-leveling unit implementation Artem Bityutskiy
2007-02-17 16:56 ` [PATCH 25/44 take 2] [UBI] EBA unit header Artem Bityutskiy
2007-02-17 16:56 ` [PATCH 26/44 take 2] [UBI] EBA unit implementation Artem Bityutskiy
2007-02-17 16:56 ` [PATCH 27/44 take 2] [UBI] bad block handling unit header Artem Bityutskiy
2007-02-17 16:56 ` [PATCH 28/44 take 2] [UBI] bad block handling unit implementation Artem Bityutskiy
2007-02-17 16:56 ` [PATCH 29/44 take 2] [UBI] update unit header Artem Bityutskiy
2007-02-17 16:56 ` [PATCH 30/44 take 2] [UBI] update unit implementation Artem Bityutskiy
2007-02-17 16:57 ` [PATCH 31/44 take 2] [UBI] accounting unit header Artem Bityutskiy
2007-02-17 16:57 ` Artem Bityutskiy [this message]
2007-02-17 16:57 ` [PATCH 33/44 take 2] [UBI] volume management " Artem Bityutskiy
2007-02-17 16:57 ` [PATCH 34/44 take 2] [UBI] volume management unit implementation Artem Bityutskiy
2007-02-17 16:57 ` [PATCH 35/44 take 2] [UBI] user-interfaces unit header Artem Bityutskiy
2007-02-17 16:57 ` [PATCH 36/44 take 2] [UBI] user-interfaces unit implementation Artem Bityutskiy
2007-02-17 16:57 ` [PATCH 37/44 take 2] [UBI] sysfs handling unit header Artem Bityutskiy
2007-02-17 16:57 ` [PATCH 38/44 take 2] [UBI] sysfs handling unit implementation Artem Bityutskiy
2007-02-17 16:57 ` [PATCH 39/44 take 2] [UBI] character devices handling sub-unit header Artem Bityutskiy
2007-02-17 16:57 ` [PATCH 40/44 take 2] [UBI] character devices handling sub-unit implementation Artem Bityutskiy
2007-02-17 16:57 ` [PATCH 41/44 take 2] [UBI] gluebi unit header Artem Bityutskiy
2007-02-17 21:14 ` Arnd Bergmann
2007-02-18 2:04 ` Josh Boyer
2007-02-18 2:15 ` Arnd Bergmann
2007-02-18 3:02 ` Josh Boyer
2007-02-18 22:37 ` Arnd Bergmann
2007-02-19 13:52 ` Artem Bityutskiy
2007-02-19 14:01 ` Josh Boyer
2007-02-19 14:07 ` Jörn Engel
2007-02-19 12:29 ` Christoph Hellwig
2007-02-19 13:30 ` Artem Bityutskiy
2007-02-17 16:57 ` [PATCH 42/44 take 2] [UBI] gluebi unit implementation Artem Bityutskiy
2007-02-17 16:58 ` [PATCH 43/44 take 2] [UBI] JFFS2 UBI support Artem Bityutskiy
2007-02-17 16:58 ` [PATCH 44/44 take 2] [UBI] update MAINTAINERS Artem Bityutskiy
2007-02-17 22:49 ` [PATCH 00/44 take 2] [UBI] Unsorted Block Images Theodore Tso
2007-02-19 12:48 ` Artem Bityutskiy
2007-02-19 14:33 ` Theodore Tso
2007-02-19 17:07 ` Artem Bityutskiy
2007-02-19 23:34 ` Theodore Tso
2007-02-20 11:54 ` Artem Bityutskiy
2007-02-25 5:51 ` Christoph Hellwig
2007-02-26 10:11 ` Artem Bityutskiy
2007-02-19 10:50 ` Christoph Hellwig
2007-02-19 17:44 ` Artem Bityutskiy
2007-02-25 5:55 ` Christoph Hellwig
2007-02-20 14:52 ` John Stoffel
2007-02-20 17:41 ` Artem Bityutskiy
2007-02-20 17:44 ` Josh Boyer
2007-02-25 5:48 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070217165705.5845.13508.sendpatchset@localhost.localdomain \
--to=dedekind@infradead.org \
--cc=dwmw2@infradead.org \
--cc=haver@vnet.ibm.com \
--cc=hch@infradead.org \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox