Re: [PATCH 15/44 take 2] [UBI] scanning unit header

Josh Boyer
2007-02-18T02:11:57Z

On Sat, Feb 17, 2007 at 06:07:46PM -0500, Theodore Tso wrote:
>
> This is a general comment that applies across your entire patchset.
> It would be a lot easier to review the patchset if you put the Docbook
> description of the function with the .c file instead of the .h file.
> This will also make it much more likely that when you or other people
> update the code function, that the documentation will get updated as
> well.
>
> I'd recommend doing this along with combining all of your *.h files
> into a ubi_private.h and ubi.h file.

I agree. Thanks for the suggestions Ted.

josh