Re: [PATCH 00/44 take 2] [UBI] Unsorted Block Images

Theodore Tso
2007-02-18T00:48:47Z

On Sat, Feb 17, 2007 at 06:54:24PM +0200, Artem Bityutskiy wrote:
> The structure of the UBI code is very simple. Whole UBI consists of units.
> Each unit has one .c file which implements it and one .h file which defines
> the interface of this unit. So I've split the UBI code so that there is
> a distinct patch for each unit header and implementations. Plus there are
> several patches like JFFS2 support, user-space-visible headers, etc.
> To realize what is the unit responsible for, glance at its header - there
> is a short description.

Artem,

This patch introduces the Makefile before any of the source
files, which means it will break "git bisect" operations. Could you
please refactor your patches so that the tree will build after any
point in your patch series?

BTW, I'm not personally found of having a separate .h file for
every .c file; in my mind a much better division is a public and
private header file.

- Ted