Re: [PATCH 00/44 take 2] [UBI] Unsorted Block Images

Christoph Hellwig
2007-02-25T05:55:24Z

On Mon, Feb 19, 2007 at 07:44:16PM +0200, Artem Bityutskiy wrote:
> On Mon, 2007-02-19 at 10:50 +0000, Christoph Hellwig wrote:
> > I think this is the wrong approach. For one thing the unit terms is
> > rather foregin in Linux
>
> I would rather disagree. Subjective. Unit is a generic word, just like
> subsystem. Unit-tests for example is a widespread word it refer to
> internal units of a big system.

What I meant is that we currently do not use the 'unit' term for code
modules in the linux kernel at all.

> Please, refine what does this exactly mean. I do not see how I should
> have sent it, sorry. OK, I've separated external headers, JFFS2 support,
> build stuff. What next?

You should not separate more but less. Generelly the review-"unit"
should be a functionally separate kenrel module, not microscopic pieces
of it. Unfortunately there are mailinglist limitations why we sometimes
have to split things up a little further, but it's usually really hard
to do useful splits at this boundary.