Re: [PATCH 07/44 take 2] [UBI] misc unit header

Artem Bityutskiy
2007-02-19T11:16:43Z

On Sat, 2007-02-17 at 17:59 -0500, Theodore Tso wrote:
> > +#define xquotise(s) #s
> > +#define quotise(s) xquotise(s)
>
> Nothing in your patch series uses this, and it's identical to
> stringify(). Please remove?

Done, thanks.

> > +/**
> > + * rb_for_each_entry - walk an RB-tree.
> > + *
> > + * @rb: a pointer to type 'struct rb_node' to to use as a loop counter
> > + * @pos: a pointer to RB-tree entry type to use as a loop counter
> > + * @root: RB-tree's root
> > + * @member: the name of the 'struct rb_node' within the RB-tree entry
> > + */
> > +#define rb_for_each_entry(rb, pos, root, member)...
>
> Shouldn't this be added to include/linux/rbtree.h?

Not sure, probably for generic we want to have several of these
depending on how the tree is traversed. But I could try to submit it to
generic code if you think it makes sens.

> > +char *strdup_len(const char *str, int len);
>
> I'm not sure this should be polluting the kernel symbol namespace,
> especially since the implementation calls ubi_assert()....
>
> It's not clear the assertion is all that useful, but if you must have
> it, why not do the check as an inline (with the assertion normally
> turned off), and then call out to kmemdup()?

Got rid of it and use kmemdup() directly, thanks.

--
Best regards,
Artem Bityutskiy (Битюцкий Артём)