Re: [PATCH 05/44 take 2] [UBI] internal common header

Christoph Hellwig
2007-02-25T05:43:48Z

On Tue, Feb 20, 2007 at 03:15:55PM +0000, David Woodhouse wrote:
> > It would be much better to use __be32 and __be64, so you get better
> > type checking, and you will catch bugs caused by forgetting to use
> > be32_to_cpu, et. al.
>
> The technique Artem uses is derived from what I do in JFFS2. It predates
> the use of sparse to catch such errors, and works in gcc for _everyone_
> without having to do anything special (like run sparse).

And makes the code clumsy and pointlessly different from all other code
we have. While no one will force you to convert your legacy point at
this code, we really shouldn't add more non-standard code. If you
really want warnings from gcc directly I doubt __attribute__((bitwise))
would be hard to implement for it.