Re: [-mm patch] arch/i386/xen/: possible cleanups

Jeremy Fitzhardinge
2007-03-01T10:53:22Z

Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - every file should #include the headers containing the prototypes for
> it's global functions
> - the xen_set_pud() prototype mismatch gcc was now able to detect
> is corrected
> - make the following needlessly global variable static:
> - events.c: virq_to_irq[]
> - make the following needlessly global functions static:
> - setup.c: xen_idle()
> - events.c: mask_evtchn()
> - events.c: unmask_evtchn()
> - mmu.c: xen_pgd_unpin()
> - remove the following unused variables:
> - setup.c: pfn_to_mfn_frame_list
> - setup.c: pfn_to_mfn_frame_list_list
> - #if 0 the following unused global function:
> - mmu.c: xen_set_pte_atomic()
> - remove the following empty unused global functions:
> - mmu.c: xen_pte_update()
> - mmu.c: xen_pte_update_defer()
> - remove the following unused EXPORT_SYMBOL:
> - setup.c: HYPERVISOR_shared_info
>

Thanks Adrian. I'd already done a lot of this locally, but I'll
double-check before posting.

> struct shared_info *HYPERVISOR_shared_info = &init_shared;
> -EXPORT_SYMBOL(HYPERVISOR_shared_info);
>

Are you sure? I thought I added this because akpm was getting compile
errors with allmodconfig.

J