Re: 2.6.20-mm2

Rafael J. Wysocki
2007-03-04T22:33:47Z

On Friday, 23 February 2007 17:36, David Brownell wrote:
> > > > > rtc_cmos 00:02: rtc core: registered rtc_cmos as rtc0
> > > > > Unable to handle kernel NULL pointer dereference at 0000000000000030 RIP:
> > > > > [<ffffffff804032c3>] rtc_sysfs_remove_device+0x23/0x50
>
> The bug isn't in rtc_cmos, but that's the only driver that would currently
> show the bug. (Triggered by finding the IRQ claimed by the legacy driver,
> result of a "but it should still be safe!" misconfiguration.)
>
> The following fixes this on my 2.6.21-rc1 system; same fix should apply
> to MM2.
>
> ===================== CUT HERE
> Fix an oops on the rtc_device_unregister() path by waiting until the
> last moment before nulling the rtc->ops vector. Fix some potential
> oopses by having the rtc_class_open()/rtc_class_close() interface
> increase the RTC's reference count while an RTC handle is available
> outside the RTC framework.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

The patch fixes the Oops on my Asus L5D and allows it to suspend to disk
(without it the problem is present in 2.6.21-rc1 and 2.6.21-rc2).

I think it should go into 2.6.21.

Greetings,
Rafael