Re: [-mm patch] LGUEST must depend on NET

Rusty Russell
2007-02-26T23:43:48Z

On Mon, 2007-02-26 at 23:23 +0100, Adrian Bunk wrote:
> CONFIG_LGUEST=y, CONFIG_NET=n results in the following compile error:
>
> <-- snip -->
>
> ...
> LD .tmp_vmlinux1
> drivers/built-in.o: In function `lguestnet_close':
> lguest_net.c:(.text+0x3b8de): undefined reference to `kfree_skb'
> drivers/built-in.o: In function `fill_slot':
> lguest_net.c:(.text+0x3ba08): undefined reference to `__alloc_skb'
> drivers/built-in.o: In function `lguestnet_open':
> lguest_net.c:(.text+0x3bada): undefined reference to `kfree_skb'
> drivers/built-in.o: In function `lguestnet_start_xmit':
> lguest_net.c:(.text+0x3bc03): undefined reference to `kfree_skb'
> drivers/built-in.o: In function `lguestnet_rcv':
> lguest_net.c:(.text+0x3bc61): undefined reference to `kfree_skb'
> lguest_net.c:(.text+0x3bc6c): undefined reference to `skb_put'
> lguest_net.c:(.text+0x3bc76): undefined reference to `eth_type_trans'
> lguest_net.c:(.text+0x3bc94): undefined reference to `netif_rx'
> drivers/built-in.o: In function `lguestnet_probe':
> lguest_net.c:(.text+0x3bcdb): undefined reference to `alloc_etherdev'
> lguest_net.c:(.text+0x3bcea): undefined reference to `ether_setup'
> lguest_net.c:(.text+0x3bdc1): undefined reference to `register_netdev'
> lguest_net.c:(.text+0x3be10): undefined reference to `unregister_netdev'
> lguest_net.c:(.text+0x3be17): undefined reference to `free_netdev'
> make[1]: *** [.tmp_vmlinux1] Error 1
>
> <-- snip -->
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

Thanks Adrian, good catch!

Rusty.