From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Alan <alan@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] siimage: DRAC4 note
Date: Tue, 20 Feb 2007 19:48:25 +0100 [thread overview]
Message-ID: <200702201948.25730.bzolnier@gmail.com> (raw)
In-Reply-To: <45DB2855.9010705@garzik.org>
On Tuesday 20 February 2007 17:56, Jeff Garzik wrote:
> Alan wrote:
> > The Dell DRAC4 has some interesting features including effectively hot
> > unplugging/replugging the virtual CD interface when the DRAC is reset.
> > This often causes drivers/ide/siimage to panic but is ok with the rather
> > smarter code in libata.
> >
> > Just note this fact in the driver docs.
> >
> > Signed-off-by: Alan Cox <alan@redhat.com>
> >
> > diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.20-mm2/drivers/ide/pci/siimage.c linux-2.6.20-mm2/drivers/ide/pci/siimage.c
> > --- linux.vanilla-2.6.20-mm2/drivers/ide/pci/siimage.c 2007-02-20 13:38:01.000000000 +0000
> > +++ linux-2.6.20-mm2/drivers/ide/pci/siimage.c 2007-02-20 13:59:44.000000000 +0000
> > @@ -26,6 +26,9 @@
> > * If you have strange problems with nVidia chipset systems please
> > * see the SI support documentation and update your system BIOS
> > * if neccessary
> > + *
> > + * If you are using a Dell DRAC4 you should use the libata driver
> > + * if possible.
>
> IMO it would probably easier on all involved if the comment noted what
> you state in the patch description.
seconded
Alan, please send me the actual OOPS if possible.
Bart
next prev parent reply other threads:[~2007-02-20 18:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-20 17:56 [PATCH] siimage: DRAC4 note Alan
2007-02-20 16:56 ` Jeff Garzik
2007-02-20 18:48 ` Bartlomiej Zolnierkiewicz [this message]
2007-02-21 1:08 ` Alan
2007-02-21 15:52 ` Alan
2007-02-23 20:11 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702201948.25730.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).