Re: [PATCH] Linux Kernel Markers Documentation

Mathieu Desnoyers
2007-02-16T03:56:08Z

Hi Randy,

* Randy Dunlap (randy.dunlap@oracle.com) wrote:
> so is the MARK() supposed to be:
> MARK(subsystem, event, ...
>
> Please make the 2 doc. lines above match the parameters...
> or the parameters match the text.
>

Fixing the paragraph below.

> > +- "%d %s %p[struct task_struct]" is the formatted string for (printk-style).
> > +- someint is an integer.
> > +- somestring is a char pointer.
> > +- current is a pointer to a struct task_struct.
> > +
> > +The expression %p[struct task_struct] is a suggested marker definition
> > +standard that could eventually be used for pointer type checking in
> > +sparse. The brackets contain the type to which the pointer refer.
> refers.
>
> > +
> > +#define SUBSYSTEM_EVENT_FORMAT "%d %s %p[struct task_struct]"
>
> Is SUBSYSTEM_EVENT_FORMAT used implicitly below? or elsewhere?
>

Yes, error follows.

> > +void probe_subsystem_event(const char *format, ...)
> > +{
> > + va_list ap;
> > + /* Declare args */
> > + unsigned int value;
> > + const char *mystr;
> > + struct task_struct *task;
> > +
> > + /* Assign args */
> > + va_start(ap, format);
> > + value = va_arg(ap, typeof(value));
> > + mystr = va_arg(ap, typeof(mystr));
> > + task = va_arg(ap, typeof(task));
> > +
> > + /* Call tracer */
> > + trace_subsystem_event(value, mystr, task);
> > +
> > + /* Or call printk */
> > + vprintk(format, ap);
> > +
> > + /* or count, check rights... */
> > +
> > + va_end(ap);
> > +}
> > +
> > +static int __init probe_init(void)
> > +{
> > + int result;
> > + result = marker_set_probe("subsystem_event",
> > + FS_CLOSE_FORMAT,
> > + probe_fs_close);
>
> Do FS_CLOSE_FORMAT and probe_fs_close() need to be defined here?
> I.e., is this a complete example?
>

should be SUBSYSTEM_EVENT_FORMAT. Will fix, thanks.

Regards,

Mathieu

--
Mathieu Desnoyers
Computer Engineering Ph.D. Candidate, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68