public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Landley <rob@landley.net>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org
Subject: [patch] Don't assume arguments to init have no period in them.
Date: Thu, 22 Feb 2007 14:40:21 -0500	[thread overview]
Message-ID: <200702221440.22078.rob@landley.net> (raw)

Signed-off-by: Rob Landley <rob@landley.net>

The kernel assumes that nobody will ever legitimately feed in a kernel command 
line option with a period in it, and the kernel is wrong: I'm feeding the 
path to a script as an argument to my init program, the name of the script 
ends in .sh.

I've been using this patch ever since 2.6.13, and I still need it.

--- linux-old/init/main.c	2005-09-09 21:42:58.000000000 -0500
+++ linux-new/init/main.c	2005-10-24 02:07:37.683498720 -0500
@@ -242,15 +242,6 @@
 	if (obsolete_checksetup(param))
 		return 0;
 
-	/*
-	 * Preemptive maintenance for "why didn't my mispelled command
-	 * line work?"
-	 */
-	if (strchr(param, '.') && (!val || strchr(param, '.') < val)) {
-		printk(KERN_ERR "Unknown boot option `%s': ignoring\n", param);
-		return 0;
-	}
-
 	if (panic_later)
 		return 0;

-- 
"Perfection is reached, not when there is no longer anything to add, but
when there is no longer anything to take away." - Antoine de Saint-Exupery

                 reply	other threads:[~2007-02-22 19:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702221440.22078.rob@landley.net \
    --to=rob@landley.net \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox