Re: [Patch 2/2] cciss: add shutdown support (replaces reboot notifier)

Christoph Hellwig
2007-02-22T21:55:09Z

On Thu, Feb 22, 2007 at 03:49:38PM -0600, James Bottomley wrote:
> On Thu, 2007-02-22 at 15:38 -0600, Mike Miller (OS Dev) wrote:
> > .remove = __devexit_p(cciss_remove_one),
> > .id_table = cciss_pci_device_id, /* id_table */
> > + .shutdown = cciss_remove_one,
>
> You need a __devexit_p() wrapper for this one too.

No. We want to call this even in the non-modular, non-hotplug
case. So we should remove __devexit from cciss_remove_one. Or
alternatively implement a separate cciss_shutdown that just does
the nessecary cache flushing, like most other drivers do.