From: "John W. Linville" <linville@tuxdriver.com>
To: Kyle McMartin <kyle@parisc-linux.org>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-kernel@vger.kernel.org, James.Bottomley@SteelEye.com,
Tejun Heo <htejun@gmail.com>, Jeff Garzik <jeff@garzik.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: [PATCH] dma-mapping-broken.h: flesh-out DMA API stubs
Date: Fri, 23 Feb 2007 09:39:38 -0500 [thread overview]
Message-ID: <20070223143938.GA5815@tuxdriver.com> (raw)
In-Reply-To: <20070223135740.GA28270@athena.road.mcmartin.ca>
On Fri, Feb 23, 2007 at 08:57:41AM -0500, Kyle McMartin wrote:
> On Fri, Feb 23, 2007 at 07:13:32AM +0100, Heiko Carstens wrote:
> > How about this for telling that an architecture doesn't support DMA?
> > At least we could get rid of dma-mapping-broken.h and don't need to
> > compile some afterwards dead code.
> >
> > Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> This like a lot better of an idea than stubbing out things which should never
> be built in the first place...
My only thought was that the intent must have been to allow compilation of a driver
that checks for DMA at runtime (via dma_supported). But, I guess dma_supported is intended
as a platform-level check?
If the DMA availability is at the arch level then such a driver could
use (albeit ugly) compile flags to cover that situation...?
Well, either way is fine with me.
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2007-02-23 14:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-23 0:59 [PATCH] dma-mapping-broken.h: flesh-out DMA API stubs John W. Linville
2007-02-23 3:42 ` Heiko Carstens
2007-02-23 6:13 ` Heiko Carstens
2007-02-23 9:50 ` Heiko Carstens
2007-02-23 13:57 ` Kyle McMartin
2007-02-23 14:39 ` John W. Linville [this message]
2007-02-26 13:57 ` [patch] Introduce CONFIG_HAS_DMA Heiko Carstens
2007-05-25 16:36 ` Dan Williams
2007-05-30 9:10 ` Cornelia Huck
2007-05-30 21:40 ` Williams, Dan J
2007-05-30 22:29 ` [PATCH] dma-mapping: prevent dma dependent code from linking on !HAS_DMA archs Dan Williams
2007-05-31 6:53 ` [patch] Introduce CONFIG_HAS_DMA Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070223143938.GA5815@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=James.Bottomley@SteelEye.com \
--cc=heiko.carstens@de.ibm.com \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=kyle@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox