From: Andrew Morton <akpm@linux-foundation.org>
To: Larry Finger <larry.finger@lwfinger.net>
Cc: pavel@ucw.cz, greg@kroah.com, linux-kernel@vger.kernel.org,
stable@kernel.org, jmforbes@linuxtx.org, zwane@arm.linux.org.uk,
tytso@mit.edu, rdunlap@xenotime.net, davej@redhat.com,
chuckw@quantumlinux.com, reviews@ml.cw.f00f.org,
mkrufky@linuxtv.org, torvalds@linux-foundation.org,
alan@lxorguk.ukuu.org.uk
Subject: Re: [patch 01/18] bcm43xx: Fix for oops on resume
Date: Sun, 25 Feb 2007 00:53:30 -0800 [thread overview]
Message-ID: <20070225005330.50ec3280.akpm@linux-foundation.org> (raw)
In-Reply-To: <45E0F4D1.9080900@lwfinger.net>
> On Sat, 24 Feb 2007 20:30:41 -0600 Larry Finger <larry.finger@lwfinger.net> wrote:
> Pavel Machek wrote:
> > Hi!
> >
> >> -stable review patch. If anyone has any objections, please let us know.
> >>
> >> ------------------
> >> From: Larry Finger <Larry.Finger@lwfinger.net>
> >>
> >> There is a kernel oops on bcm43xx when resuming due to an overly tight timeout loop.
> >>
> >> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> >> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> >>
> >> ---
> >> drivers/net/wireless/bcm43xx/bcm43xx.h | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> --- linux-2.6.18.7.orig/drivers/net/wireless/bcm43xx/bcm43xx.h
> >> +++ linux-2.6.18.7/drivers/net/wireless/bcm43xx/bcm43xx.h
> >> @@ -21,7 +21,7 @@
> >> #define PFX KBUILD_MODNAME ": "
> >>
> >> #define BCM43xx_SWITCH_CORE_MAX_RETRIES 50
> >> -#define BCM43xx_IRQWAIT_MAX_RETRIES 50
> >> +#define BCM43xx_IRQWAIT_MAX_RETRIES 100
> >>
> >> #define BCM43xx_IO_SIZE 8192
> >
> > I'm sorry, but this does not look like fixing an oops. It may make it
> > go away for you, or make it less probable, but it certainly can't fix
> > it.
>
> Upon resume, it was taking 65 times through the loop, which caused an oops. We think it is due to a
> slow-clock setting at that point, but it certainly does get rid of the oops. This change has also
> eliminated the odd oops seen by a few users.
>
Pavel's point is that the driver shouldn't oops the kernel if
BCM43xx_IRQWAIT_MAX_RETRIES is exceeded.
Presumably, the driver will oops if bcm43xx_chip_init() fails for other
reasons?
next prev parent reply other threads:[~2007-02-25 8:56 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070221014413.282048309@mini.kroah.org>
2007-02-21 1:49 ` [patch 00/18] 2.6.18-stable review Greg KH
2007-02-21 1:49 ` [patch 01/18] bcm43xx: Fix for oops on resume Greg KH
2007-02-23 5:25 ` Pavel Machek
2007-02-25 2:30 ` Larry Finger
2007-02-25 8:53 ` Andrew Morton [this message]
2007-02-21 1:49 ` [patch 02/18] bcm43xx: Fix for oops on ampdu status Greg KH
2007-02-21 1:49 ` [patch 03/18] Dont leak NT bit into next task Greg KH
2007-02-21 10:00 ` Giuseppe Bilotta
2007-02-21 17:14 ` Jan Engelhardt
2007-02-21 17:20 ` Chuck Ebbert
2007-02-22 15:29 ` Adrian Bunk
2007-02-22 16:56 ` Andi Kleen
2007-02-21 1:50 ` [patch 04/18] SCSI: add missing cdb clearing in scsi_execute() Greg KH
2007-02-21 1:50 ` [patch 05/18] IB/srp: Fix FMR mapping for 32-bit kernels and addresses above 4G Greg KH
2007-02-21 1:50 ` [patch 06/18] i2c: fix broken ds1337 initialization Greg KH
2007-02-21 1:50 ` [patch 07/18] grow_buffers() infinite loop fix (CVE-2006-5757, CVE-2006-6060) Greg KH
2007-02-21 1:50 ` [patch 08/18] hfs_fill_super returns success even if no root inode (CVE-2006-6056) Greg KH
2007-02-21 1:50 ` [patch 09/18] IB/mad: Fix race between cancel and receive completion Greg KH
2007-02-21 1:50 ` [patch 10/18] dvb-core: fix bug in CRC-32 checking on 64-bit systems Greg KH
2007-02-21 1:50 ` [patch 11/18] v4l: cx2341x audio_properties is an u16, not u8 Greg KH
2007-02-21 1:50 ` [patch 12/18] v4l: cx88: Fix leadtek_eeprom tagging Greg KH
2007-02-21 1:51 ` [patch 13/18] V4L: cx88: Fix lockup on suspend Greg KH
2007-02-22 1:14 ` Michael Krufky
2007-02-23 23:50 ` Greg KH
2007-02-21 1:51 ` [patch 14/18] V4L: Fix quickcam communicator driver for big endian architectures Greg KH
2007-02-21 1:51 ` [patch 15/18] V4L: fix ks0127 status flags Greg KH
2007-02-21 1:51 ` [patch 16/18] V4L: tveeprom: autodetect LG TAPC G701D as tuner type 37 Greg KH
2007-02-21 1:51 ` [patch 17/18] V4L: buf_qbuf: fix videobuf_queue->stream corruption and lockup Greg KH
2007-02-21 1:51 ` [patch 18/18] x86_64: fix 2.6.18 regression - PTRACE_OLDSETOPTIONS should be accepted Greg KH
2007-02-21 11:55 ` [patch 00/18] 2.6.18-stable review S.Çağlar Onur
2007-02-21 17:34 ` [stable] " Greg KH
2007-02-21 18:30 ` S.Çağlar Onur
2007-02-21 18:45 ` Ismail Dönmez
2007-02-22 5:42 ` Willy Tarreau
2007-02-26 0:00 ` Adrian Bunk
2007-02-26 0:18 ` Adrian Bunk
2007-03-05 13:44 ` S.Çağlar Onur
2007-03-05 19:26 ` Greg KH
2007-03-05 20:13 ` S.Çağlar Onur
2007-02-23 20:21 ` Hugh Dickins
2007-02-23 20:34 ` [stable] " Chris Wright
2007-02-23 21:13 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070225005330.50ec3280.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=chuckw@quantumlinux.com \
--cc=davej@redhat.com \
--cc=greg@kroah.com \
--cc=jmforbes@linuxtx.org \
--cc=larry.finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mkrufky@linuxtv.org \
--cc=pavel@ucw.cz \
--cc=rdunlap@xenotime.net \
--cc=reviews@ml.cw.f00f.org \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox