From: Adrian Bunk <bunk@stusta.de>
To: zippel@linux-m68k.org, Andrew Morton <akpm@linux-foundation.org>
Cc: kbuild-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: [2.6 patch] kconfig: abort configuration with recursive dependencies
Date: Mon, 26 Feb 2007 00:18:33 +0100 [thread overview]
Message-ID: <20070225231833.GC29575@stusta.de> (raw)
A recursive kconfig dependency is a bug that has to be fixed, and that
might currently not be noted until booting the built kernel.
Currently, the warning that a recursive dependency was detected scrolls
away during "make oldconfig", and often people don't notice until they
booted the kernel and note something like "Why is there no IPV6 support?".
This patch therefore lets the configuration fail if kconfig found a
recursive dependency.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.20-mm2/scripts/kconfig/symbol.c.old 2007-02-25 19:27:07.000000000 +0100
+++ linux-2.6.20-mm2/scripts/kconfig/symbol.c 2007-02-25 19:30:32.000000000 +0100
@@ -792,7 +792,7 @@
struct property *prop;
if (sym->flags & SYMBOL_CHECK) {
- printf("Warning! Found recursive dependency: %s", sym->name);
+ printf("Error: Found recursive dependency: %s", sym->name);
return sym;
}
if (sym->flags & SYMBOL_CHECKED)
@@ -820,7 +820,7 @@
printf(" %s", sym->name);
if (sym2 == sym) {
printf("\n");
- sym2 = NULL;
+ exit(1);
}
}
sym->flags &= ~SYMBOL_CHECK;
reply other threads:[~2007-02-25 23:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070225231833.GC29575@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@linux-foundation.org \
--cc=kbuild-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox