From: Andi Kleen <ak@suse.de>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.21-rc1] x86 signal number delivery fixes
Date: Sun, 25 Feb 2007 23:39:48 +0100 [thread overview]
Message-ID: <200702252339.48933.ak@suse.de> (raw)
In-Reply-To: <200702251147.l1PBl9ab003231@harpo.it.uu.se>
On Sunday 25 February 2007 12:47, Mikael Pettersson wrote:
> The invokation of signal handlers on x86 has several bugs
> in its treatment of the signal number parameter:
>
> - the i386 kernel passes the raw not the translated signal number
> in EAX to non-SA_SIGINFO handlers compiled with -mregparm=3;
> the value passed on the stack is correct, and SA_SIGINFO handlers
> are also invoked correctly
> - the x86-64 kernel's ia32 emulation for SA_SIGINFO handlers also
> passes the wrong (untranslated) signal number in EAX; the value
> on the stack is correct
> - the x86-64 kernel's ia32 emulation for non-SA_SIGINFO handlers
> passes the wrong (untranslated) signal number both on the stack
> and in EAX
Nobody should be using that signal translation code anymore. Certainly
nothing in tree. Perhaps it would be better to just rip it out.
If you have a user you should submit it.
-Andi
next prev parent reply other threads:[~2007-02-25 22:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-25 11:47 [PATCH 2.6.21-rc1] x86 signal number delivery fixes Mikael Pettersson
2007-02-25 22:39 ` Andi Kleen [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-02-25 23:03 Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702252339.48933.ak@suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@it.uu.se \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox