Re: request_module: runaway loop modprobe net-pf-1 (is Re: Linux 2.6.21-rc1)

Greg KH
2007-02-22T06:09:32Z

On Thu, Feb 22, 2007 at 12:34:17PM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote:
> In article <20070222.110440.47345562.yoshfuji@linux-ipv6.org> (at Thu, 22 Feb 2007 11:04:40 +0900 (JST)), YOSHIFUJI Hideaki / ?$B5HF#1QL@ <yoshfuji@linux-ipv6.org> says:
>
> > In article <87ps8372bf.fsf@duaron.myhome.or.jp> (at Thu, 22 Feb 2007 04:12:04 +0900), OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> says:
> >
> > > YOSHIFUJI Hideaki / ?$B5HF#1QL@ <yoshfuji@linux-ipv6.org> writes:
> > >
> > > > In article <Pine.LNX.4.64.0702202043280.4043@woody.linux-foundation.org> (at Tue, 20 Feb 2007 20:53:45 -0800 (PST)), Linus Torvalds <torvalds@linux-foundation.org> says:
> > > >
> > > >> But there's a ton of architecture updates (arm, mips, powerpc, x86, you
> > > >> name it), ACPI updates, and lots of driver work. And just a lot of
> > > >> cleanups.
> > > >
> > > > I cannot boot 2.6.21-rc1; it falls into OOM-Killer.
> > > >
> > > > Interesting error message I can see is:
> > > > request_module: runaway loop modprobe net-pf-1
> > > >
> > > > After bisecting, the commit
> > > > Driver core: let request_module() send a /sys/modules/kmod/-uevent
> > > > (id c353c3fb0700a3c17ea2b0237710a184232ccd7f) is to blame.
> > > >
> > > > Reverting it fixes the issue to me.
> > >
> > > /sbin/hotplug needs some module, but request_module() call /sbin/hotplug loop?
> > > Hm.. does the patch fix the problem?
> >
> > Yes, it absolutely fixes the issue.
>
> Several options:
>
> - To revert the changeset to blame

No.

> - To apply Ogawa-san's (or other appropriate) patch

His patch just avoids the issue, but isn't correct.

> - To select UNIX in init/Kconfig:KMOD

I like this one, but some people might still want it as a module (I
really don't know why, does anyone else???)

> I think it would be a good idea to rate-limit frequency of requesing a
> single module, anyway.

Yes, if we can detect the loop, that would be best.

Or, maybe the easiest thing is to just not do the netlink call if it's
asking for the network module? :)

Any other suggestions or thoughts?

thanks,

greg k-h