Re: request_module: runaway loop modprobe net-pf-1 (is Re: Linux 2.6.21-rc1)

Anders Larsen
2007-02-22T10:28:12Z

On 2007-02-22 01:18:09, Greg KH wrote:
> On Thu, Feb 22, 2007 at 06:16:23AM +0900, OGAWA Hirofumi wrote:
> > E.g. something calls the request_modle(), and if hotplug is using
> > socket(PF_UNIX) and af_unix is module, it also calls request_modle()?
> >
> > Just my guess though...
>
> Ugh, why does anyone make af_unix a module these days. I thought only
> Debian was that foolish... :)

Then how about making CONFIG_UNIX bool instead of tristate?

Cheers
Anders

diff --git a/net/unix/Kconfig b/net/unix/Kconfig
index 5a69733..b589254 100644
--- a/net/unix/Kconfig
+++ b/net/unix/Kconfig
@@ -3,7 +3,7 @@
#

config UNIX
- tristate "Unix domain sockets"
+ bool "Unix domain sockets"
---help---
If you say Y here, you will include support for Unix domain sockets;
sockets are the standard Unix mechanism for establishing and
@@ -13,9 +13,5 @@ config UNIX
an embedded system or something similar, you therefore definitely
want to say Y here.

- To compile this driver as a module, choose M here: the module will be
- called unix. Note that several important services won't work
- correctly if you say M here and then neglect to load the module.
-
Say Y unless you know what you are doing.