From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Oleg Nesterov <oleg@tv-sign.ru>,
Gautham R Shenoy <ego@in.ibm.com>,
Johannes Berg <johannes@sipsolutions.net>,
LKML <linux-kernel@vger.kernel.org>,
Srivatsa Vaddagiri <vatsa@in.ibm.com>
Subject: Re: Problem with freezable workqueues
Date: Wed, 28 Feb 2007 09:54:24 +0100 [thread overview]
Message-ID: <20070228085424.GA8442@elf.ucw.cz> (raw)
In-Reply-To: <200702280057.36198.rjw@sisk.pl>
Hi!
> > I'm afraid this is racy. We can't touch *cwq, it may be freed. Suppose
> > that another thread does destroy_workqueue(), and we thaw that thread
> > before cwq->thread.
>
> Okay, in that case I'd suggest removing create_freezeable_workqueue() and
> make all workqueues nonfreezable once again for 2.6.21 (as far as I know, only
> the two XFS workqueues are affected).
>
> Pavel, would that be acceptable?
Not sure... I really dislike XFS running while we are doing
swsusp. I'd like to move in direction of freezeable workqueues in the
future.
Anyway, if it gets us out of current trouble... yes I guess we can do
it.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2007-02-28 8:54 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-27 21:51 Problem with freezable workqueues Rafael J. Wysocki
2007-02-27 23:28 ` Oleg Nesterov
2007-02-27 23:36 ` Johannes Berg
2007-02-28 0:00 ` Rafael J. Wysocki
2007-02-28 0:00 ` Johannes Berg
2007-02-28 18:06 ` Gautham R Shenoy
2007-02-27 23:57 ` Rafael J. Wysocki
2007-02-28 0:01 ` Johannes Berg
2007-02-28 0:08 ` Rafael J. Wysocki
2007-02-28 1:14 ` Nigel Cunningham
2007-02-28 10:59 ` Rafael J. Wysocki
2007-02-28 20:36 ` Johannes Berg
2007-02-28 3:07 ` Srivatsa Vaddagiri
2007-02-28 8:48 ` Oleg Nesterov
2007-02-28 9:10 ` Srivatsa Vaddagiri
2007-02-28 9:43 ` Oleg Nesterov
2007-02-28 11:09 ` Rafael J. Wysocki
2007-02-28 18:17 ` Gautham R Shenoy
2007-02-28 18:41 ` Rafael J. Wysocki
2007-02-28 8:54 ` Pavel Machek [this message]
2007-02-28 3:01 ` Srivatsa Vaddagiri
2007-02-28 3:51 ` Srivatsa Vaddagiri
2007-02-28 11:11 ` Rafael J. Wysocki
2007-02-28 13:17 ` Srivatsa Vaddagiri
2007-02-28 13:27 ` Srivatsa Vaddagiri
2007-02-28 17:41 ` Rafael J. Wysocki
2007-02-28 17:40 ` Rafael J. Wysocki
2007-02-28 19:17 ` Rafael J. Wysocki
2007-02-28 19:32 ` Oleg Nesterov
2007-02-28 19:43 ` Rafael J. Wysocki
2007-02-28 20:08 ` Oleg Nesterov
2007-02-28 20:25 ` Rafael J. Wysocki
2007-02-28 20:35 ` Oleg Nesterov
2007-02-28 22:39 ` Rafael J. Wysocki
2007-02-28 22:44 ` Pavel Machek
2007-02-28 23:54 ` [PATCH] Make XFS workqueues nonfreezable Rafael J. Wysocki
2007-03-01 8:03 ` Andrew Morton
2007-03-01 9:15 ` Pavel Machek
2007-03-01 9:25 ` Andrew Morton
2007-02-28 21:16 ` Problem with freezable workqueues Pavel Machek
2007-03-06 0:30 ` Johannes Berg
2007-03-06 20:31 ` Rafael J. Wysocki
2007-03-06 22:25 ` Nigel Cunningham
2007-03-06 22:57 ` Rafael J. Wysocki
2007-03-07 23:10 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070228085424.GA8442@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=ego@in.ibm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=rjw@sisk.pl \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox