* fix implicit declaration in nv_backlight.
@ 2007-02-28 17:36 Dave Jones
2007-02-28 21:13 ` Michael Hanselmann
0 siblings, 1 reply; 4+ messages in thread
From: Dave Jones @ 2007-02-28 17:36 UTC (permalink / raw)
To: Linux Kernel; +Cc: Michael Hanselmann, Antonino Daplas
drivers/video/nvidia/nv_backlight.c: In function 'nvidia_bl_init':
drivers/video/nvidia/nv_backlight.c:103: error: implicit declaration of function 'pmac_has_backlight_type'
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6.20.noarch/drivers/video/nvidia/nv_backlight.c~ 2007-02-20 22:25:15.000000000 -0500
+++ linux-2.6.20.noarch/drivers/video/nvidia/nv_backlight.c 2007-02-20 22:25:31.000000000 -0500
@@ -12,6 +12,9 @@
#include <linux/backlight.h>
#include <linux/fb.h>
#include <linux/pci.h>
+#ifdef __powerpc__
+#include <asm/backlight.h>
+#endif
#include "nv_local.h"
#include "nv_type.h"
#include "nv_proto.h"
--
http://www.codemonkey.org.uk
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: fix implicit declaration in nv_backlight.
2007-02-28 17:36 fix implicit declaration in nv_backlight Dave Jones
@ 2007-02-28 21:13 ` Michael Hanselmann
2007-02-28 21:26 ` Dave Jones
2007-02-28 21:44 ` Antonino A. Daplas
0 siblings, 2 replies; 4+ messages in thread
From: Michael Hanselmann @ 2007-02-28 21:13 UTC (permalink / raw)
To: Dave Jones, Linux Kernel, Antonino Daplas
On Wed, Feb 28, 2007 at 12:36:25PM -0500, Dave Jones wrote:
> +#ifdef __powerpc__
Is __powerpc__ defined when cross compiling? I'd rather use
CONFIG_PMAC_BACKLIGHT instead of it.
Greets,
Michael
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: fix implicit declaration in nv_backlight.
2007-02-28 21:13 ` Michael Hanselmann
@ 2007-02-28 21:26 ` Dave Jones
2007-02-28 21:44 ` Antonino A. Daplas
1 sibling, 0 replies; 4+ messages in thread
From: Dave Jones @ 2007-02-28 21:26 UTC (permalink / raw)
To: Michael Hanselmann; +Cc: Linux Kernel, Antonino Daplas
On Wed, Feb 28, 2007 at 10:13:24PM +0100, Michael Hanselmann wrote:
> On Wed, Feb 28, 2007 at 12:36:25PM -0500, Dave Jones wrote:
> > +#ifdef __powerpc__
>
> Is __powerpc__ defined when cross compiling? I'd rather use
> CONFIG_PMAC_BACKLIGHT instead of it.
Sounds ok to me.
Dave
--
http://www.codemonkey.org.uk
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: fix implicit declaration in nv_backlight.
2007-02-28 21:13 ` Michael Hanselmann
2007-02-28 21:26 ` Dave Jones
@ 2007-02-28 21:44 ` Antonino A. Daplas
1 sibling, 0 replies; 4+ messages in thread
From: Antonino A. Daplas @ 2007-02-28 21:44 UTC (permalink / raw)
To: linux-kernel; +Cc: davej, linux-kernel, adaplas
> On Wed, Feb 28, 2007 at 12:36:25PM -0500, Dave Jones wrote:
>> +#ifdef __powerpc__
>
> Is __powerpc__ defined when cross compiling? I'd rather use
> CONFIG_PMAC_BACKLIGHT instead of it.
Agree with this too.
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-02-28 21:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-28 17:36 fix implicit declaration in nv_backlight Dave Jones
2007-02-28 21:13 ` Michael Hanselmann
2007-02-28 21:26 ` Dave Jones
2007-02-28 21:44 ` Antonino A. Daplas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox