From: Andrew Morton <akpm@linux-foundation.org>
To: tony@bakeyournoodle.com (Tony Breeds)
Cc: Linux Kernel ML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] Fix soft lockup with iSeries viocd driver
Date: Thu, 1 Mar 2007 00:37:48 -0800 [thread overview]
Message-ID: <20070301003748.5a571916.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070301035640.GS4575@bakeyournoodle.com>
On Thu, 1 Mar 2007 14:56:40 +1100 tony@bakeyournoodle.com (Tony Breeds) wrote:
> From: Tony Breeds <tony@bakeyournoodle.com>
>
> Fix soft lockup with iSeries viocd driver, caused by eventually calling
> end_that_request_first() with nr_bytes 0.
>
> The lockup is triggered by hald, interrogating the device.
>
What causes the lockup, and how does this patch fix it?
>
> Index: linux-2.6.20-rc5/drivers/cdrom/viocd.c
> ===================================================================
> --- linux-2.6.20-rc5.orig/drivers/cdrom/viocd.c
> +++ linux-2.6.20-rc5/drivers/cdrom/viocd.c
> @@ -376,6 +376,25 @@ static int send_request(struct request *
> return 0;
> }
>
> +static void viocd_end_request(struct request *req, int uptodate)
> +{
> + int nsectors = req->hard_nr_sectors;
Your email client replaces tabs with spaces. I fixed this patch up.
next prev parent reply other threads:[~2007-03-01 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-01 3:56 [PATCH] Fix soft lockup with iSeries viocd driver Tony Breeds
2007-03-01 8:37 ` Andrew Morton [this message]
2007-03-01 8:48 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070301003748.5a571916.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tony@bakeyournoodle.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox