From: Andrew Morton <akpm@linux-foundation.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [patch 03/22] fix deadlock in balance_dirty_pages
Date: Thu, 1 Mar 2007 00:41:11 -0800 [thread overview]
Message-ID: <20070301004111.c56f4fd1.akpm@linux-foundation.org> (raw)
In-Reply-To: <E1HMgmg-0001mc-00@dorka.pomaz.szeredi.hu>
On Thu, 01 Mar 2007 09:37:06 +0100 Miklos Szeredi <miklos@szeredi.hu> wrote:
> > Sigh. What's this about i_mutex? That appears to be some critical
> > information which _still_ isn't being communicated.
> >
>
> This:
>
> ssize_t generic_file_aio_write(struct kiocb *iocb, const struct iovec *iov,
> unsigned long nr_segs, loff_t pos)
> {
> struct file *file = iocb->ki_filp;
> struct address_space *mapping = file->f_mapping;
> struct inode *inode = mapping->host;
> ssize_t ret;
>
> BUG_ON(iocb->ki_pos != pos);
>
> mutex_lock(&inode->i_mutex);
> ret = __generic_file_aio_write_nolock(iocb, iov, nr_segs,
> &iocb->ki_pos);
> mutex_unlock(&inode->i_mutex);
>
>
> It's in the stack trace. I thought it was obvious.
No, it is not obvious.
I'm just not going to apply weird hacks to work around a bug which
I do not understand, and I have spent way too much time trying to understand
this one.
So let us persist.
Please fully describe the role of i_mutex in this hang.
next prev parent reply other threads:[~2007-03-01 8:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070227223809.684624012@szeredi.hu>
[not found] ` <20070227223911.472192712@szeredi.hu>
2007-03-01 6:58 ` [patch 03/22] fix deadlock in balance_dirty_pages Andrew Morton
2007-03-01 7:35 ` Miklos Szeredi
2007-03-01 8:27 ` Andrew Morton
2007-03-01 8:37 ` Miklos Szeredi
2007-03-01 8:41 ` Andrew Morton [this message]
2007-03-01 8:58 ` Miklos Szeredi
[not found] ` <20070227223914.057085427@szeredi.hu>
2007-03-01 7:11 ` [patch 04/22] fix deadlock in throttle_vm_writeout Andrew Morton
2007-03-01 7:48 ` Miklos Szeredi
2007-02-27 23:14 [patch 00/22] misc VFS/VM patches and fuse writable shared mapping support Miklos Szeredi
2007-02-27 23:14 ` [patch 03/22] fix deadlock in balance_dirty_pages Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070301004111.c56f4fd1.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox