Re: [PATCH -mm][Take 2] clocksource init adjustments (fix bug #7426)

David Miller
2007-03-02T23:30:47Z

From: john stultz <johnstul@us.ibm.com>
Date: Fri, 02 Mar 2007 15:24:00 -0800

> On Fri, 2007-03-02 at 12:32 -0800, David Miller wrote:
> > From: john stultz <johnstul@us.ibm.com>
> > Date: Fri, 02 Mar 2007 11:58:11 -0800
> >
> > > Oh! Sorry! Yea, looking at it more the ioremap isn't actually necessary,
> > > as we can use hpet_readl() instead of re-calculating the hpet base
> > > address pointer.
> > >
> > > I'll fix this up (and find an HPET enabled x86_64 box to test it on) and
> > > get a patch to you shortly.
> >
> > Not to pressure you John but I'd really like to see this go
> > in soon, it does fix real bugs such as the Radeon FB issue
> > I pointed out the other week.
>
> Here's my second try at this. This time I caught three bugs from the
> last patch (all in x86_64):
> 1) Calling ioremap too early in the HPET code (which is unnecessary)
> 2) hpet_period local variable aliasing
> 3) forgot to re-add call to init_tsc_clocksource()
>
> I boot tested on two x86_64 boxes (one ACPI PM and the other HPET).
> However it probably should still go through a bit of testing in -mm to
> make sure all the quirks are shaken out.

Agreed and it looks good to me after going over it a few times.