Re: Keyboard stops working after *lock [Was: 2.6.21-rc2-mm1]

Jiri Kosina
2007-03-11T21:47:29Z

On Sun, 11 Mar 2007, Jiri Slaby wrote:

> > - /* make sure the unused bits in the last byte are zeros */
> > - if (count > 0 && size > 0)
> > - data[(offset+count*size-1)/8] = 0;
> > -
> No, this doesn't help -- -rc3-mm2 minus this behaves exactly the same.
> -rc3 without this patch too.
> Going to try to revert the commits mentioned above.

Hmm, strange, I did bet that this would have solved the problem, as the
code is for sure bogus and could be causing these kinds of problems (I
have already scheduled it for removal in the HID tree as an upstream fix)
- it could zero out even the bits which are used and have been previously
set.

I would think that reverting the two commits I have mentioned is not going
to help, if this did not help, but it's always worth trying.

Otherwise, would you care to bisect?

What is the keyboard in question, please? (vendor/product ids).

Thanks,

--
Jiri Kosina