Re: [patch] timer/hrtimer: take per cpu locks in sane order

Heiko Carstens
2007-03-02T21:41:52Z

> > +/*
> > + * double_timer_lock/unlock are used to ensure that on cpu hotplug the
> > + * per cpu timer locks are always taken in the same order.
> > + */
> > +static void __devinit double_timer_lock(tvec_base_t *base1,
> > + tvec_base_t *base2, int ind)
> > + __acquires(base1->lock)
> > + __acquires(base2->lock)
>
> hm. Can we not just pass in the spinlock_t*'s and use a common function?
>
> void double_spin_lock(spinlock_t *l1, spinlock_t *l2, int ind);
>
> that way it has nothing to do with timers and can potentially be used
> elsewhere in the kernel, too.
>
> (what does "ind" mean?)

Sure. Will put a static inline function into include/linux/spinlock.h.
"ind" is supposed to be the short form of "indicator".