From: Greg KH <greg@kroah.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH,RFC] pci: do not mark exported functions as __devinit
Date: Fri, 2 Mar 2007 15:34:14 -0800 [thread overview]
Message-ID: <20070302233414.GA15038@kroah.com> (raw)
In-Reply-To: <20070302230214.GC22555@uranus.ravnborg.org>
On Sat, Mar 03, 2007 at 12:02:14AM +0100, Sam Ravnborg wrote:
> >
> > Yes, we allow them to be exported globally, as other init code might
> > need to call them, like these functions.
> >
> > So yes, I think we need to find a way to fix the warning tools, as the
> > code is correct here.
>
> This was the patch that I made to ignore these.
> It is on top of other pending changes to modpost so it will not
> apply.
> I had to check for _ksymtab* because we have various
> section names for ksymtab. (_gpl, _future etc.)
Looks good to me. Thanks for fixing all of these warnings.
greg k-h
prev parent reply other threads:[~2007-03-02 23:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-27 9:27 [PATCH,RFC] pci: do not mark exported functions as __devinit Sam Ravnborg
2007-03-02 20:47 ` Greg KH
2007-03-02 22:55 ` Sam Ravnborg
2007-03-02 22:59 ` [PATCH] pci: fix section mismatch warning Sam Ravnborg
2007-03-02 23:27 ` patch pci-fix-section-mismatch-warning.patch added to gregkh-2.6 tree gregkh
2007-03-02 23:02 ` [PATCH,RFC] pci: do not mark exported functions as __devinit Sam Ravnborg
2007-03-02 23:34 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070302233414.GA15038@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox