From: Arnd Bergmann <arnd@arndb.de>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-kernel@vger.kernel.org, Joel Becker <joel.becker@oracle.com>
Subject: Re: [PATCH] configfs: add missing mutex_unlock()
Date: Sun, 4 Mar 2007 15:10:19 +0100 [thread overview]
Message-ID: <200703041510.20127.arnd@arndb.de> (raw)
In-Reply-To: <20070304133812.GC8519@APFDCB5C>
On Sunday 04 March 2007 14:38:12 Akinobu Mita wrote:
> @@ -1168,8 +1168,10 @@ int configfs_register_subsystem(struct c
>
> err = -ENOMEM;
> dentry = d_alloc(configfs_sb->s_root, &name);
> - if (!dentry)
> + if (!dentry) {
> + mutex_unlock(&configfs_sb->s_root->d_inode->i_mutex);
> goto out_release;
> + }
>
> d_add(dentry, NULL);
This should be changed to jump to a new exit point, before the mutex_unlock
at the end of the function. Having multiple places in the function that
release the same lock easily leads to the kind of bug you are fixing here.
Arnd <><
next prev parent reply other threads:[~2007-03-04 14:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-04 13:38 [PATCH] configfs: add missing mutex_unlock() Akinobu Mita
2007-03-04 14:10 ` Arnd Bergmann [this message]
2007-03-04 15:16 ` Akinobu Mita
2007-03-05 21:42 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703041510.20127.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akinobu.mita@gmail.com \
--cc=joel.becker@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox