Re: 2.6.21-rc2-mm1

Andrew Morton
2007-03-05T10:14:55Z

On Fri, 02 Mar 2007 16:56:42 +0100 Michal Piotrowski <michal.k.k.piotrowski@gmail.com> wrote:

> Hi,
>
> Andrew Morton napisał(a):
> > Temporarily at
> >
> > http://userweb.kernel.org/~akpm/2.6.21-rc2-mm1/
> >
>
> Possible fix for
>
> nvidiafb-bring-back-generic-ddc-reading.patch
>
> drivers/built-in.o: In function `nvidia_probe_i2c_connector':
> /mnt/md0/devel/linux-mm/drivers/video/nvidia/nv_i2c.c:166: undefined reference to `fb_ddc_read'
> make[1]: *** [.tmp_vmlinux1] Error 1
> make: *** [_all] Error 2
>
> Regards,
> Michal
>
> --
> Michal K. K. Piotrowski
> LTG - Linux Testers Group (PL)
> (http://www.stardust.webpages.pl/ltg/)
> LTG - Linux Testers Group (EN)
> (http://www.stardust.webpages.pl/linux_testers_group_en/)
>
> Signed-off-by: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
>
> --- linux-work/drivers/video/Makefile 2007-03-02 16:38:17.000000000 +0100
> +++ linux-mm/drivers/video/Makefile 2007-03-02 16:49:23.000000000 +0100
> @@ -33,6 +33,7 @@ obj-$(CONFIG_FB_PM3) += pm3fb.o
> obj-$(CONFIG_FB_MATROX) += matrox/
> obj-$(CONFIG_FB_RIVA) += riva/ vgastate.o
> obj-$(CONFIG_FB_NVIDIA) += nvidia/
> +obj-$(CONFIG_FB_NVIDIA_I2C) += fb_ddc.o
> obj-$(CONFIG_FB_ATY) += aty/ macmodes.o
> obj-$(CONFIG_FB_ATY128) += aty/ macmodes.o
> obj-$(CONFIG_FB_RADEON) += aty/

Alas, with this applied, i386 allmodconfig breaks:

drivers/built-in.o: In function `fb_ddc_read':
: undefined reference to `i2c_transfer'
make: *** [.tmp_vmlinux1] Error 1

because allmodconfig gave me:

CONFIG_FB_NVIDIA_I2C=y