From: "Joerg Roedel" <joerg.roedel@amd.com>
To: "Michael Tokarev" <mjt@tls.msk.ru>
Cc: discuss@x86-64.org, "Andi Kleen" <ak@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86_64: add reporting of SVM flags to /proc/cpuinfo
Date: Mon, 5 Mar 2007 16:06:25 +0100 [thread overview]
Message-ID: <20070305150625.GJ30318@amd.com> (raw)
In-Reply-To: <45EC2D43.8010108@tls.msk.ru>
On Mon, Mar 05, 2007 at 05:46:27PM +0300, Michael Tokarev wrote:
> Joerg Roedel wrote:
> > +++ b/arch/x86_64/kernel/setup.c
> > + static char *x86_svm_flags[] = {
> > + "npt",
> > + "lbrv",
> > + "svmlock",
> > + };
>
> A nitpick:
>
> static const char *const x86_svm_flags[] = ... ?
Right. Its better to mark the array as const. Will wait
for more comments and send an updated patch soon.
Thanks,
Joerg
--
Joerg Roedel
Operating System Research Center
AMD Saxony LLC & Co. KG
next prev parent reply other threads:[~2007-03-05 15:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-05 14:36 [PATCH 0/2] add reporting of SVM flags to /proc/cpuinfo Joerg Roedel
2007-03-05 14:39 ` [PATCH 1/2] x86_64: " Joerg Roedel
2007-03-05 14:46 ` Michael Tokarev
2007-03-05 15:06 ` Joerg Roedel [this message]
2007-03-05 15:25 ` Andi Kleen
2007-03-05 15:58 ` [discuss] " Dave Jones
2007-03-06 12:46 ` Joerg Roedel
2007-03-05 14:42 ` [PATCH 2/2] i386: " Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070305150625.GJ30318@amd.com \
--to=joerg.roedel@amd.com \
--cc=ak@suse.de \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjt@tls.msk.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox