From: Andrew Morton <akpm@linux-foundation.org>
To: Andres Salomon <dilinger@debian.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andi Kleen <ak@suse.de>
Subject: Re: [PATCH]: i386: make x86_64 tsc header require i386 rather than vice-versa
Date: Mon, 5 Mar 2007 19:10:21 -0800 [thread overview]
Message-ID: <20070305191021.eb152377.akpm@linux-foundation.org> (raw)
In-Reply-To: <45E8E729.2040906@debian.org>
On Fri, 02 Mar 2007 22:10:33 -0500 Andres Salomon <dilinger@debian.org> wrote:
> Prior to commit 95492e4646e5de8b43d9a7908d6177fb737b61f0 ([PATCH] x86:
> rewrite SMP TSC sync code), the headers in asm-i386 did not really
> require anything in include/asm-x86_64. This means that distributions
> such as fedora did not include asm-x86_64 in kernel-devel headers for
> i386. Ingo's commit changed that, and broke things. This is easy
> enough to hack around in package builds by just including asm-x86_64 on
> i386, but that's kind of annoying. If anything, x86_64 should depend
> upon i386, not the other way around.
>
> This patch changes it so that asm-x86_64/tsc.h includes asm-i386/tsc.h,
> rather than vice-versa.
Agree - I don't see any gain in making the references be bidirectional, and
it just makes life more complicated. Knowing "x86_64 always references
i386" is a useful mental mark.
That, plus the kernel-headers point which you describe..
<looks at early_printk.c>
prev parent reply other threads:[~2007-03-06 3:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-03 3:10 [PATCH]: i386: make x86_64 tsc header require i386 rather than vice-versa Andres Salomon
2007-03-06 3:10 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070305191021.eb152377.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@suse.de \
--cc=dilinger@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox