* [S390] cio: Call cancel_halt_clear even when actl == 0.
@ 2007-03-05 22:42 Martin Schwidefsky
0 siblings, 0 replies; only message in thread
From: Martin Schwidefsky @ 2007-03-05 22:42 UTC (permalink / raw)
To: linux-kernel, linux-s390; +Cc: cornelia.huck
From: Cornelia Huck <cornelia.huck@de.ibm.com>
[S390] cio: Call cancel_halt_clear even when actl == 0.
The subchannel may just be status pending, even with actl == 0. We
must go through the cancel_halt_clear procedure to put the subchannel
into a defined state.
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---
drivers/s390/cio/device_fsm.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -urpN linux-2.6/drivers/s390/cio/device_fsm.c linux-2.6-patched/drivers/s390/cio/device_fsm.c
--- linux-2.6/drivers/s390/cio/device_fsm.c 2007-03-05 22:51:58.000000000 +0100
+++ linux-2.6-patched/drivers/s390/cio/device_fsm.c 2007-03-05 22:51:58.000000000 +0100
@@ -144,8 +144,8 @@ ccw_device_cancel_halt_clear(struct ccw_
ret = stsch(sch->schid, &sch->schib);
if (ret || !sch->schib.pmcw.dnv)
return -ENODEV;
- if (!sch->schib.pmcw.ena || sch->schib.scsw.actl == 0)
- /* Not operational or no activity -> done. */
+ if (!sch->schib.pmcw.ena)
+ /* Not operational -> done. */
return 0;
/* Stage 1: cancel io. */
if (!(sch->schib.scsw.actl & SCSW_ACTL_HALT_PEND) &&
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-03-05 22:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-05 22:42 [S390] cio: Call cancel_halt_clear even when actl == 0 Martin Schwidefsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox