Re: [patch 4/6] mm: merge populate and nopage into fault (fixes nonlinear)

Nick Piggin
2007-03-07T09:52:16Z

On Wed, Mar 07, 2007 at 10:22:52AM +0100, Ingo Molnar wrote:
>
> * Nick Piggin <npiggin@suse.de> wrote:
>
> > After these patches, I don't think there is too much burden. The main
> > thing left really is just the objrmap stuff, but that is just handled
> > with a minimal 'dumb' algorithm that doesn't cost much.
>
> ok. What do you think about the sys_remap_file_pages_prot() thing that
> Paolo has done in a nicely split up form - does that complicate things
> in any fundamental way? That is what is useful to UML.

Last time I looked (a while ago), the only issue I had was that he was
doing a weird special case rather than using another !present pte bit
for his "nonlinear protection" ptes.

I think he fixed that now and so it should be quite good now.