Re: [patch 4/6] mm: merge populate and nopage into fault (fixes nonlinear)

Miklos Szeredi
2007-03-07T09:26:18Z

> >
> > Look in page_mkclean(). Where does it handle non-linear mappings?
> >
>
> OK, I'd forgotten about that. It won't break dirty memory accounting,
> but it'll potentially break dirty memory balancing.
>
> If we have the wrong page (due to nonlinear), page_check_address() will
> fail and we'll leave the pte dirty.

It won't even get that far, because it only looks at vmas on
mapping->i_mmap, and not on i_mmap_nonlinear.

Miklos