From: Andrew Morton <akpm@linux-foundation.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: "Petr Tesa__ík" <ptesarik@suse.cz>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Nick Piggin" <nickpiggin@yahoo.com.au>
Subject: Re: [PATCH] remove_arg_zero() rewrite
Date: Wed, 7 Mar 2007 14:41:01 -0800 [thread overview]
Message-ID: <20070307144101.f97cfa53.akpm@linux-foundation.org> (raw)
In-Reply-To: <1173305397.4868.4.camel@lappy>
On Wed, 07 Mar 2007 23:09:57 +0100
Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> On Wed, 2007-02-21 at 15:41 -0800, Andrew Morton wrote:
>
> > I mean.... what the hell?
> >
> > As you appear to have managed to work out what the sorry thing is trying to
> > do, would you have time to simply rip it out and completely rewrite it,
> > including a nice comment telling the world what this function's function is?
> >
> > Because what we have there is beyond repairing.
>
> Something like so?
> Boots uml seemingly without errors.
>
> ---
> Rewrite remove_arg_zero() to be more parseable by untwisted minds.
>
Sorry, Nick already had a go at this:
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc2/2.6.21-rc2-mm2/broken-out/exec-fix-remove_arg_zero.patch
But your patch has a nice comment and has to be better ;)
next prev parent reply other threads:[~2007-03-07 22:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-20 13:29 [PATCH] free pages in remove_arg_zero() Petr Tesařík
2007-02-21 23:41 ` Andrew Morton
2007-03-07 22:09 ` [PATCH] remove_arg_zero() rewrite Peter Zijlstra
2007-03-07 22:41 ` Andrew Morton [this message]
2007-03-07 22:55 ` Peter Zijlstra
2007-03-07 23:05 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070307144101.f97cfa53.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=ptesarik@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox